Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker #42

Merged
merged 39 commits into from
Dec 18, 2024
Merged

Datepicker #42

merged 39 commits into from
Dec 18, 2024

Conversation

nighto
Copy link
Collaborator

@nighto nighto commented Dec 5, 2024

No description provided.

@nighto
Copy link
Collaborator Author

nighto commented Dec 6, 2024

  • Remove whitespace from package files.
  • Double check if US calendar start on Sunday or Monday.

Edit: it really is Sunday: https://www.calendarr.com/united-states/first-day-of-the-week/#:~:text=In%20many%20parts%20of%20Europe,beginning%20of%20the%20working%20week.

@nighto
Copy link
Collaborator Author

nighto commented Dec 10, 2024

Next steps:

  • Remove errors also from DateTimeRangePicker
  • Refactor TimePicker to work with string instead of date object, exposing an object with hours and minutes
  • Create an example with all together.

@nighto nighto marked this pull request as ready for review December 12, 2024 12:24
@mkrause
Copy link
Collaborator

mkrause commented Dec 12, 2024

  • Need to make all the stories use a hardcoded date/time so that it doesn't cause issues with visual testing
  • Fix vertical alignment of the caret icon

- Use hardcoded time on stories, so they don't keep changing
- CSS fixes
@mkrause
Copy link
Collaborator

mkrause commented Dec 13, 2024

There's a warning in the console, let's fix this. Basically, need to spell out the class in full rather than relying on Sass-style concatenation:

warnings when minifying css:
▲ [WARNING] Cannot use type selector "--selected" directly after nesting selector "&" [css-syntax-error]

    <stdin>:2441:28:
      2441 │ .react-datepicker__day:not(&--selected):hover {
           │                             ~~~~~~~~~~
           ╵                             :is(--selected)

  CSS nesting syntax does not allow the "&" selector to come before a type selector. You can wrap this selector in ":is(...)" as a workaround. This restriction exists to avoid problems with SASS nesting, where the same syntax means something very different that has no equivalent in real CSS (appending a suffix to the parent selector).

- Remove invalid CSS rule
- Change TimePicker signature to return a Time object with hours and minutes,
  instead of a time string.
@nighto nighto requested a review from mkrause December 18, 2024 09:41
@nighto nighto merged commit d683455 into master Dec 18, 2024
3 checks passed
@nighto nighto deleted the datepicker branch December 18, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants