Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all TypeScript errors (except Tabs which is ignored for now) #30

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mkrause
Copy link
Collaborator

@mkrause mkrause commented Nov 19, 2024

I've resolved all type errors, except the ones in Tabs.stories.tsx which needs a bit of investigation. Ignored these for now and created an issue: #29

This will allow us to start enforcing zero type errors in CI.

@mkrause mkrause requested a review from nighto November 19, 2024 15:29
@mkrause mkrause self-assigned this Nov 19, 2024
@mkrause mkrause mentioned this pull request Nov 19, 2024
Copy link
Collaborator

@nighto nighto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no warnings running npm run check-types.

@nighto nighto merged commit 18f0a1a into master Nov 20, 2024
@nighto nighto deleted the mkrause/241119-fix-typescript-errors branch November 20, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants