Skip to content

Commit

Permalink
Use 2px from global variable
Browse files Browse the repository at this point in the history
  • Loading branch information
nighto committed Nov 19, 2024
1 parent 37bd86e commit ba35b87
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/components/forms/controls/Tag/Tag.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,13 @@
.bk-tag {
@include bk.component-base(bk-tag);

--small-padding: 2px; // currently missing from Figma

background: bk.$theme-tag-background-default;
border-radius: 2px;
border-radius: bk.$size-2;
color: bk.$theme-tag-text-default;
display: flex;
align-items: center;
font-size: bk.$font-size-xs;
padding: var(--small-padding) 0 3px bk.$spacing-2;
padding: bk.$size-2 0 bk.$size-3 bk.$spacing-2;

.bk-tag__icon {
--icon-size: 7px;
Expand All @@ -25,7 +23,7 @@
height: var(--icon-size);
color: bk.$theme-tag-icon-default;
cursor: pointer;
padding: var(--small-padding) bk.$spacing-2 var(--small-padding) bk.$spacing-2;
padding: bk.$size-2 bk.$spacing-2 bk.$size-2 bk.$spacing-2;
}
}
}
2 changes: 2 additions & 0 deletions src/styling/variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,10 @@ $spacing-16: math.div(192, 14) * 1rem !default; // ~192px
$spacing-17: math.div(224, 14) * 1rem !default; // ~224px
$spacing-18: math.div(256, 14) * 1rem !default; // ~256px

// these sizes do not match Figma variables
$size-1: math.div(1, 14) * 1rem !default; // ~1px
$size-2: math.div(2, 14) * 1rem !default; // ~2px
$size-3: math.div(3, 14) * 1rem !default; // ~3px


//
Expand Down

0 comments on commit ba35b87

Please sign in to comment.