Code Review fixes: turn ternary into if/else block; onChange fn fix

fortanix · Nov 14, 2024 · 108c636 · 108c636
1 parent 2c94f8e
commit 108c636
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/components/forms/fields/CheckboxGroup/CheckboxGroup.stories.tsx b/src/components/forms/fields/CheckboxGroup/CheckboxGroup.stories.tsx
@@ -26,9 +26,11 @@ export default {
   render: (args) => {
     const [selectedColors, setSelectedColors] = React.useState<Array<Color>>([]);
     const handleCheckboxChange = (color: Color) => {
-      selectedColors.includes(color) ?
-        setSelectedColors(selectedColors.filter(c => c !== color)) :
+      if (selectedColors.includes(color)) {
+        setSelectedColors(selectedColors.filter(c => c !== color));
+      } else {
         setSelectedColors([...selectedColors, color]);
+      }
     };
     return (
       <CheckboxGroup {...args}>
@@ -37,7 +39,7 @@ export default {
             key={color}
             label={color}
             checked={selectedColors.includes(color)}
-            onChange={() => handleCheckboxChange(color as Color)}
+            onChange={() => { handleCheckboxChange(color as Color); }}
           />
         )}
       </CheckboxGroup>