Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form-level error reporting #1

Merged
merged 3 commits into from
May 27, 2024
Merged

fix: form-level error reporting #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a748524
fix: form-level error reporting
nhedger May 25, 2024
5c4ebdf
formatting
nhedger May 25, 2024
4cac86a
apply suggestions
nhedger May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/addons/formkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,17 @@ export default <F extends RequestPayload>(initialFields?: F, formLevelErrorName?
on('error', (errors, node) => {
const _formLevelErrorName = formLevelErrorName ? formLevelErrorName : node.name;

let formErrorMessages: string | undefined;
/**
* If one of the errors should be displayed at the form level, we extract
* it from the errors object and set it as a form level error.
*/
const formErrorMessages: string[] = [];
if (_formLevelErrorName in errors) {
formErrorMessages = errors[_formLevelErrorName];

formErrorMessages[0] = errors[_formLevelErrorName];
delete errors[_formLevelErrorName];
}

node.setErrors(_formLevelErrorName, errors);
node.setErrors(formErrorMessages, errors);
});

on('finish', (_, node) => {
Expand Down