-
Notifications
You must be signed in to change notification settings - Fork 4
fix: updates version tags #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update CI workflows and the podspec: publish-pod.yml now triggers on GitHub release events (type: released), adds repository contents read permission, inserts a runner hardening step before checkout, and updates several action versions while preserving CocoaPods install and trunk publish steps. FormbricksSDK.podspec changes the Git source tag from Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/publish-pod.yml(1 hunks).github/workflows/sonarqube.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-and-analyze
🔇 Additional comments (7)
.github/workflows/publish-pod.yml (4)
2-3: LGTM! Minimal permissions follow least-privilege principle.Adding
contents: readpermission explicitly follows security best practices by granting only the minimum required access.
12-15: LGTM! Security hardening enhances workflow security.Adding the
harden-runnerstep withegress-policy: auditis a good security practice that monitors all outbound network calls from the workflow. The use of a commit SHA for the action version (instead of a mutable tag) prevents potential supply chain attacks.
18-19: LGTM! Updated checkout action with security best practices.The checkout action has been updated to use a commit SHA reference, which is more secure than using version tags. The step name is also more descriptive.
22-22: LGTM! Updated Ruby setup action.The
ruby/setup-rubyaction has been updated to use a commit SHA reference for security..github/workflows/sonarqube.yml (3)
2-3: LGTM! Consistent security posture across workflows.Adding explicit
contents: readpermission maintains least-privilege access, consistent with the changes inpublish-pod.yml.
18-21: LGTM! Security hardening consistent with publish workflow.The
harden-runnerstep implementation is identical topublish-pod.yml, providing consistent security monitoring across all workflows. Using the same commit SHA reference ensures both workflows use the same verified version of the security action.
23-24: LGTM! Checkout action updated consistently.The checkout action uses the same commit SHA reference as
publish-pod.yml(v4.2.2), ensuring consistency across workflows. The step name change to "Checkout repository" also aligns with the publish workflow.
|
mattinannt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes and added hardening to the runners. Looks good :-)



Updates the version tags checks, the new versions will not contain the letter
v