ci(refactor): extract build setup logic into setup-build #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tueda
force-pushed
the
ci-setup-build-action
branch
from
022fd5b to
fbe271c
Compare
|
Changed from |
tueda
commented
Mar 16, 2025
| # awalsh128/cache-apt-pkgs-action does not allow empty packages argument. | ||
| # See: https://github.com/awalsh128/cache-apt-pkgs-action/issues/149 | ||
| # As a workaround, we need to check if any packages need to be installed. | ||
| - name: Install dependencies (Ubuntu) |
There was a problem hiding this comment.
This can be simplified if awalsh128/cache-apt-pkgs-action#154 is merged.
tueda
force-pushed
the
ci-setup-build-action
branch
from
fbe271c to
4bf9299
Compare
|
Rebased. Added features: |
Create a new composite action "setup-build" by extracting common setup logic from the test/deploy workflows. This action sets up the build environment and runs the configure script.
tueda
force-pushed
the
ci-setup-build-action
branch
from
4bf9299 to
a908805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extracts the build setup logic into a composite action called
setup-buildto avoid repeating similar steps in different jobs. The setup process includes installing dependencies and libraries, extracting tarballs, runningautoreconf, and executingconfigure.In the future, if we need to elaborate further on setting up libraries (including building and caching), such as MPI or FLINT, we can manage them all in one place.
There are several ways to organize shared logic in GitHub Actions:
setup-buildneeds to modify$LIBRARY_PATHetc.)This patch adopts the last option. To mitigate the drawback, I added lines like
### Initialize setup ###in therun:field, which will appear in the logs.