Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor list field #117

Merged
merged 12 commits into from
Mar 6, 2024
Merged

Refactor list field #117

merged 12 commits into from
Mar 6, 2024

Conversation

MiroslavPetrik
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 78.48101% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 84.24%. Comparing base (f8201da) to head (730e307).
Report is 28 commits behind head on next.

Files Patch % Lines
src/atoms/types.ts 0.00% 11 Missing and 1 partial ⚠️
src/atoms/upload-atom/uploadAtom.ts 0.00% 2 Missing and 1 partial ⚠️
src/atoms/extendAtom.ts 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #117      +/-   ##
==========================================
- Coverage   91.17%   84.24%   -6.94%     
==========================================
  Files         101       87      -14     
  Lines        2720     1834     -886     
  Branches      213      107     -106     
==========================================
- Hits         2480     1545     -935     
- Misses        240      285      +45     
- Partials        0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MiroslavPetrik MiroslavPetrik merged commit 8bc738f into next Mar 6, 2024
1 of 3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 6, 2024
# [4.1.0-next.1](v4.0.16...v4.1.0-next.1) (2024-03-06)

### Features

* **listField:** Refactor list field ([#117](#117)) ([8bc738f](8bc738f)), closes [#116](#116)
Copy link

github-actions bot commented Mar 6, 2024

🎉 This PR is included in version 4.1.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

MiroslavPetrik added a commit that referenced this pull request Mar 6, 2024
BREAKING CHANGE: listAtom extracted to `@form-atoms/list-atom` which is now a required peer Dependency for `listField()`
BREAKING CHANGE: The `builder` config property from `listField` was renamed to `fields`.
BREAKING CHANGE: The `builder` config property no longer accepts `FieldAtom` as return type. `FormFields` must be returned.
@MiroslavPetrik MiroslavPetrik deleted the refactor-list-field branch March 6, 2024 12:35
github-actions bot pushed a commit that referenced this pull request Mar 6, 2024
# [5.0.0](v4.0.16...v5.0.0) (2024-03-06)

### Features

* **listField:** Refactor list field ([#117](#117)) ([13f5745](13f5745))

### BREAKING CHANGES

* **listField:** listAtom extracted to `@form-atoms/list-atom` which is now a required peer Dependency for `listField()`
* **listField:** The `builder` config property from `listField` was renamed to `fields`.
* **listField:** The `builder` config property no longer accepts `FieldAtom` as return type. `FormFields` must be returned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants