NEW @W-19772057@ Enhanced rule selector support #363
Merged
+235
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
force-pushed
the
d/W-19772057
branch
from
204e13f to
d188bb3
Compare
| `No rule with name '%s' and engine '%s' exists among the selected rules.`, | ||
|
|
||
| SelectorCannotBeEmpty: | ||
| `Rule selectors cannot be empty strings.`, |
There was a problem hiding this comment.
Suggested change
| `Rule selectors cannot be empty strings.`, | |
| `Rule selectors can't be empty strings.`, |
| `Rule selectors cannot be empty strings.`, | ||
|
|
||
| SelectorLooksIncorrect: | ||
| `Rule selector '%s' looks incorrect. Make sure that parentheses are balanced, and that all subselectors are joined by a colon (:) or comma (,).`, |
There was a problem hiding this comment.
Suggested change
| `Rule selector '%s' looks incorrect. Make sure that parentheses are balanced, and that all subselectors are joined by a colon (:) or comma (,).`, | |
| `Rule selector '%s' looks incorrect. Make sure that parentheses are balanced and that all subselectors are joined by a colon (:) or comma (,).`, |
| `Rule selector '%s' looks incorrect. Make sure that parentheses are balanced, and that all subselectors are joined by a colon (:) or comma (,).`, | ||
|
|
||
| EngineRunResultsMissing: | ||
| `Could to get results for engine '%s' since they are missing from the overall run results. Most likely the engine did not run.`, |
There was a problem hiding this comment.
Suggested change
| `Could to get results for engine '%s' since they are missing from the overall run results. Most likely the engine did not run.`, | |
| `Couldn't get results for engine '%s' since they're missing from the overall run results. Most likely the engine didn't run.`, |
There was a problem hiding this comment.
Nice spot @jshackell-sfdc!
randi274
reviewed
Sep 30, 2025
| stubEngine2Rules: ['stub2RuleC'] | ||
| }, | ||
| { | ||
| selector: 'Recommended,3:Performance', // Equivalent to "(Recommended,4):Performance", or "(Recommended:Performance),(4:Performance)" |
There was a problem hiding this comment.
Suggested change
| selector: 'Recommended,3:Performance', // Equivalent to "(Recommended,4):Performance", or "(Recommended:Performance),(4:Performance)" | |
| selector: 'Recommended,3:Performance', // Equivalent to "(Recommended,3):Performance", or "(Recommended:Performance),(3:Performance)" |
There was a problem hiding this comment.
Oh, good catch. Thanks.
| case: 'colons and commas are nested via parentheses', | ||
| selectors: ['(Recommended:Performance),(stubEngine2:2),(stubEngine2:DoesNotExist)'] | ||
| } | ||
| ])('When $case, then we get correct union and intersection behavior', async ({selectors}) => { |
There was a problem hiding this comment.
Is there a logical limit to how many unions and intersections there can be, or does the limit not exist?
There was a problem hiding this comment.
The algorithm is just standard recursion, so there's no hardcoded limit.
randi274
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, rule selectors could use colons (
:) to join multiple criteria with a logical AND (e.g.,Performance:2is all Performance rules with severity 2).After this change, they can also use commas (
,) to join criteria with a logical OR (Performance,2would be all Performance rules and all rules with severity 2). Furthermore, parentheses can be used to create groups that are handled effectively as logical booleans.E.g.,
(Performance:2),(eslint:1)would be all performance rules with sev2, and every ESLint Sev1 rule.