Fix login webview scrolling. #2797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmathurin
approved these changes
Oct 29, 2025
JohnsonEricAtSalesforce
approved these changes
Oct 30, 2025
Contributor
JohnsonEricAtSalesforce
left a comment
JohnsonEricAtSalesforce
left a comment
There was a problem hiding this comment.
✅ This looks brilliant. Thanks, @brandonpage ⭐️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is really only a couple lines of code that add the correct insets and padding, but they needed to be put in the correct place. Furthermore, older versions (< API 30) of Android need to not have the fix because it will break their working scrolling... which is annoying because you cannot apply modifier values in an if outside of scope of the
AndroidView.I have tested this fix on several physical and virtual devices that include API 28, 29, 30, 33 and 36.
login_scrolling_api_29.mp4
login_scrolling_api_33.mp4
splitscreen_login_scrolling_api_33.mp4
Landscape orientation behaves exactly the same as the above videos.
The only issue I could not overcome is that the optional bottom app bar button shows above the keyboard for API 28 and 29 devices but is still hidden behind the keyboard for API 30+.