Skip to content

Conversation

@JohnsonEricAtSalesforce
Copy link
Contributor

🎸 Ready For Review 🥁

This corrects the network_id field when registering for SFDC push notifications, which was incorrectly set to the community URL instead of the community id.

@wmathurin
Copy link
Contributor

Maybe we could add tests for this method by using the approach used in AuthenticationUtilities / AuthenticationUtilitiesTest
where we have a bunch of parameters that take lambda functions but default to calling existing helper methods?

…r User Accounts With Community URL (Test Updates)
@JohnsonEricAtSalesforce
Copy link
Contributor Author

Maybe we could add tests for this method by using the approach used in AuthenticationUtilities / AuthenticationUtilitiesTest where we have a bunch of parameters that take lambda functions but default to calling existing helper methods?

As it turns out, I wrote a set of tests around PushService earlier in the yet. We could add a test for this value like this commit 👉🏻 d914477

@JohnsonEricAtSalesforce JohnsonEricAtSalesforce merged commit bf71435 into forcedotcom:dev Oct 17, 2025
4 of 6 checks passed
@JohnsonEricAtSalesforce JohnsonEricAtSalesforce deleted the bugfix/w-19964705_msdk-android-push-notification-registration-failure-for-user-accounts-with-community-url branch October 17, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants