Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREQ-1188 - Add optional column 'Retrieval service point' #1240

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

Terala-Priyanka
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka commented Dec 2, 2024

Purpose

UIREQ-1188 - Add "Retrieval service point" column in Request app

Approach

Add optional column 'Retrieval service point' which is unchecked by default in 'show columns list. This column is sortable as well.
Maximum coverage is achieved.

Screenshots

chrome_Q0rn8eBSIR

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Dec 2, 2024

Jest Unit Test Statistics

       1 files  ±0       62 suites  ±0   1m 36s ⏱️ -4s
   798 tests +1     798 ✔️ +1  0 💤 ±0  0 ±0 
1 107 runs  +1  1 107 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 959c9ab. ± Comparison against base commit f9ea4b9.

♻️ This comment has been updated with latest results.

@Terala-Priyanka Terala-Priyanka requested a review from a team December 3, 2024 08:26
@UladzislauKutarkin UladzislauKutarkin requested a review from a team December 3, 2024 08:31
@Terala-Priyanka Terala-Priyanka merged commit 7edd21a into master Dec 3, 2024
5 checks passed
@Terala-Priyanka Terala-Priyanka deleted the UIREQ-1188 branch December 3, 2024 11:02
@Dmitriy-Litvinenko Dmitriy-Litvinenko restored the UIREQ-1188 branch January 9, 2025 14:07
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the UIREQ-1188 branch January 9, 2025 19:59
Dmitriy-Litvinenko pushed a commit that referenced this pull request Jan 10, 2025
* UIREQ-1188 - Add optional column 'Retrieval service point'

* Male retieval sp column sortable

* add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants