UIREQMED-23 Use caret for react peerDep #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://folio-org.atlassian.net/browse/UIREQMED-23 As package managers become more strict about peerDeps specifications all being in agreement with eachother, we want apps to have coordinating versions with their anticipated platform… (pnpm complained about an 18.2.0 hard dependency in the app while the platform, stripes, etc, ask for ^18.2.0 - incompatible since the caret pulls in a later version. The version specified in the ui-module exists here because it’s the version from ui-app-template that’s automatically copied over when the create command is executed with stripes-cli
|
zburke
approved these changes
Jun 9, 2024
Dmitriy-Litvinenko
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As package managers become more strict about peerDep specifications all being in agreement with eachother, we want apps to have coordinating versions with their anticipated platform… (
pnpmcomplains about a hard dependency on[email protected]in the app while the platform, stripes, etc, ask for^18.2.0or~18.2.0- incompatible since the caret or tilde will both pull in a later version.)The reason this version is specified this way here is because it is from
ui-app-templatethat is automatically copied over when the create command is executed withstripes-cli.There is a PR on that repo that remedies this. (Merged)
Refs
UIREQMED-23