Skip to content

Commit

Permalink
UIREQMED-1: Updated module after created with stripes-cli
Browse files Browse the repository at this point in the history
  • Loading branch information
Dmitriy-Litvinenko committed Dec 21, 2023
1 parent e61e2de commit ff010f0
Show file tree
Hide file tree
Showing 32 changed files with 307 additions and 534 deletions.
13 changes: 12 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"extends": "@folio/eslint-config-stripes",
"parser": "@babel/eslint-parser",
"extends": "@folio/eslint-config-stripes",
"overrides": [
{
"files": [ "src/**/tests/*", "**/*.test.js", "test/**/*" ],
Expand All @@ -12,5 +12,16 @@
],
"env": {
"jest": true
},
"settings": {
"import/resolver": {
"alias": {
"map": [
["__mock__", "./test/jest/__mock__"],
["fixtures", "./test/jest/fixtures"],
["helpers", "./test/jest/helpers"]
]
}
}
}
}
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ artifacts
npm-debug.log
yarn.lock
package-lock.json
junit.xml
yarn-error.log
.vscode
.idea
junit.xml
6 changes: 6 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.DS_Store
*.swp
*.swo
node_modules
yarn.lock

2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@

## 1.0.0

* New app created with stripes-cli
* New app created with stripes-cli. Updated module after created with stripes-cli. Refs UIREQMED-1.
90 changes: 90 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
<!--
If you have a relevant JIRA issue number, please put it in the issue title.
Example: UIREQMED-1: Add pull request template
-->

<!--
You have added reviewers to the pull request.
Required reviewers this is a personal that responsible for current repository
in according with https://wiki.folio.org/display/REL/Team+vs+module+responsibility+matrix
-->

## Purpose
<!--
Why are you making this change? There is nothing more important
to provide to the reviewer and to future readers than the cause
that gave rise to this pull request. Be careful to avoid circular
statements like "the purpose is to update the schema." and
instead provide an explanation like "there is more data to be provided and stored for Purchase Orders
which is currently missing in the schema"
The purpose may seem self-evident to you now, but the standard to
hold yourself to should be "can a developer parachuting into this
project reconstruct the necessary context merely by reading this
section."
-->

## Approach
<!--
How does this change fulfill the purpose? It's best to talk
high-level strategy and avoid code-splaining the commit history.
The goal is not only to explain what you did, but help other
developers *work* with your solution in the future.
-->

## Refs
<!--
If you have a relevant JIRA issue, add a link directly to the issue URL here.
Example: https://issues.folio.org/browse/UIREQMED-1
-->

## Screenshots
<!-- OPTIONAL
One picture is literally worth a thousand words. When the feature is
an interaction, an animated GIF is best. Most of the time it helps to
include "before" and "after" screenshots to quickly demonstrate the
value of the feature.
-->

<!-- OPTIONAL
#### TODOS and Open Questions
- [ ] Use GitHub checklists. When solved, check the box and explain the answer.
-->

<!-- OPTIONAL
## Learning
Help out not only your reviewer, but also your fellow developer!
Sometimes there are key pieces of information that you used to come up
with your solution. Don't let all that hard work go to waste! A
pull request is a *perfect opportunity to share the learning that
you did. Add links to blog posts, patterns, libraries or addons used
to solve this problem.
-->

## Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
- [ ] I've added appropriate record to the CHANGELOG.md
- Does this PR meet or exceed the expected quality standards?
- [ ] Code coverage on new code is 80% or greater
- [ ] Duplications on new code is 3% or less
- [ ] There are no major code smells or security issues
- Does this introduce breaking changes?
- [ ] If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
- [ ] There are no breaking changes in this PR.

If there are breaking changes, please **STOP** and consider the following:

- What other modules will these changes impact?
- Do JIRAs exist to update the impacted modules?
- [ ] If not, please create them
- [ ] Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
- [ ] Do they have all they appropriate links to blocked/related issues?
- Are the JIRAs under active development?
- [ ] If not, contact the project's PO and make sure they're aware of the urgency.
- Do PRs exist for these changes?
- [ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.
Binary file added icons/app.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions icons/app.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ module.exports = {
path.join(__dirname, './test/jest/setupFiles.js'),
],
};

34 changes: 22 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
{
"name": "@folio/requests-mediated",
"version": "1.1.0",
"description": "requests-mediated",
"description": "Mediated requests",
"main": "src/index.js",
"repository": "",
"repository": "folio-org/ui-requests-mediated",
"publishConfig": {
"registry": "https://repository.folio.org/repository/npm-folio/"
},
"license": "Apache-2.0",
"scripts": {
"start": "stripes serve",
"lint": "eslint .",
"lintfix": "eslint . --fix",
"test": "yarn run test:jest",
"test:jest": "jest --ci --coverage --colors",
"build": "stripes build --output ./output",
"build-mod-descriptor": "stripes mod descriptor --full --strict | jq '.[]' > module-descriptor.json ",
"formatjs-compile": "stripes translate compile",
"lint": "eslint .",
"test": "jest"
"formatjs-compile": "formatjs compile-folder --ast --format simple ./translations/ui-requests-mediated ./translations/ui-requests-mediated/compiled"
},
"devDependencies": {
"@babel/core": "^7.21.0",
Expand All @@ -24,18 +29,16 @@
"@folio/eslint-config-stripes": "^7.0.0",
"@folio/jest-config-stripes": "^2.0.0",
"@folio/stripes": "^9.1.0",
"@folio/stripes-cli": "^2.6.0 || ^3.0.0",
"@folio/stripes-cli": "^3.0.0",
"@folio/stripes-core": "^10.1.0",
"core-js": "^3.6.4",
"eslint": "^7.32.0",
"history": "^4.10.1",
"history": "^5.0.0",
"lodash": "^4.17.21",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-intl": "^6.4.4",
"react-redux": "^8.0.5",
"react-router-dom": "^5.2.0",
"redux": "^4.0.5",
"regenerator-runtime": "^0.13.3"
},
"dependencies": {
Expand All @@ -54,17 +57,24 @@
"settings"
],
"displayName": "ui-requests-mediated.meta.title",
"route": "/requestsmediated",
"route": "/requests-mediated",
"icons": [
{
"name": "app",
"alt": "Mediated requests",
"title": "Mediated requests manager"
}
],
"okapiInterfaces": {},
"permissionSets": [
{
"permissionName": "module.requests-mediated.enabled",
"displayName": "UI: requests-mediated module is enabled",
"displayName": "UI: Mediated requests module is enabled",
"visible": true
},
{
"permissionName": "settings.requests-mediated.enabled",
"displayName": "Settings (requests-mediated): display list of settings pages",
"displayName": "Settings (Mediated requests): display list of settings pages",
"subPermissions": [
"settings.enabled"
],
Expand Down
Empty file.
29 changes: 0 additions & 29 deletions src/components/greeting-modal/greeting-modal.js

This file was deleted.

35 changes: 0 additions & 35 deletions src/components/greeting-modal/greeting-modal.test.js

This file was deleted.

1 change: 0 additions & 1 deletion src/components/greeting-modal/index.js

This file was deleted.

1 change: 0 additions & 1 deletion src/components/new-app-greeting/index.js

This file was deleted.

Empty file.
15 changes: 0 additions & 15 deletions src/components/new-app-greeting/new-app-greeting.js

This file was deleted.

40 changes: 0 additions & 40 deletions src/components/new-app-greeting/new-app-greeting.test.js

This file was deleted.

Loading

0 comments on commit ff010f0

Please sign in to comment.