-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
UIREQMED-1: Updated module after created with stripes-cli
- Loading branch information
1 parent
e61e2de
commit ff010f0
Showing
32 changed files
with
307 additions
and
534 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,7 @@ artifacts | |
npm-debug.log | ||
yarn.lock | ||
package-lock.json | ||
junit.xml | ||
yarn-error.log | ||
.vscode | ||
.idea | ||
junit.xml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
.DS_Store | ||
*.swp | ||
*.swo | ||
node_modules | ||
yarn.lock | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
<!-- | ||
If you have a relevant JIRA issue number, please put it in the issue title. | ||
Example: UIREQMED-1: Add pull request template | ||
--> | ||
|
||
<!-- | ||
You have added reviewers to the pull request. | ||
Required reviewers this is a personal that responsible for current repository | ||
in according with https://wiki.folio.org/display/REL/Team+vs+module+responsibility+matrix | ||
--> | ||
|
||
## Purpose | ||
<!-- | ||
Why are you making this change? There is nothing more important | ||
to provide to the reviewer and to future readers than the cause | ||
that gave rise to this pull request. Be careful to avoid circular | ||
statements like "the purpose is to update the schema." and | ||
instead provide an explanation like "there is more data to be provided and stored for Purchase Orders | ||
which is currently missing in the schema" | ||
The purpose may seem self-evident to you now, but the standard to | ||
hold yourself to should be "can a developer parachuting into this | ||
project reconstruct the necessary context merely by reading this | ||
section." | ||
--> | ||
|
||
## Approach | ||
<!-- | ||
How does this change fulfill the purpose? It's best to talk | ||
high-level strategy and avoid code-splaining the commit history. | ||
The goal is not only to explain what you did, but help other | ||
developers *work* with your solution in the future. | ||
--> | ||
|
||
## Refs | ||
<!-- | ||
If you have a relevant JIRA issue, add a link directly to the issue URL here. | ||
Example: https://issues.folio.org/browse/UIREQMED-1 | ||
--> | ||
|
||
## Screenshots | ||
<!-- OPTIONAL | ||
One picture is literally worth a thousand words. When the feature is | ||
an interaction, an animated GIF is best. Most of the time it helps to | ||
include "before" and "after" screenshots to quickly demonstrate the | ||
value of the feature. | ||
--> | ||
|
||
<!-- OPTIONAL | ||
#### TODOS and Open Questions | ||
- [ ] Use GitHub checklists. When solved, check the box and explain the answer. | ||
--> | ||
|
||
<!-- OPTIONAL | ||
## Learning | ||
Help out not only your reviewer, but also your fellow developer! | ||
Sometimes there are key pieces of information that you used to come up | ||
with your solution. Don't let all that hard work go to waste! A | ||
pull request is a *perfect opportunity to share the learning that | ||
you did. Add links to blog posts, patterns, libraries or addons used | ||
to solve this problem. | ||
--> | ||
|
||
## Pre-Merge Checklist | ||
Before merging this PR, please go through the following list and take appropriate actions. | ||
- [ ] I've added appropriate record to the CHANGELOG.md | ||
- Does this PR meet or exceed the expected quality standards? | ||
- [ ] Code coverage on new code is 80% or greater | ||
- [ ] Duplications on new code is 3% or less | ||
- [ ] There are no major code smells or security issues | ||
- Does this introduce breaking changes? | ||
- [ ] If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly | ||
- [ ] There are no breaking changes in this PR. | ||
|
||
If there are breaking changes, please **STOP** and consider the following: | ||
|
||
- What other modules will these changes impact? | ||
- Do JIRAs exist to update the impacted modules? | ||
- [ ] If not, please create them | ||
- [ ] Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc. | ||
- [ ] Do they have all they appropriate links to blocked/related issues? | ||
- Are the JIRAs under active development? | ||
- [ ] If not, contact the project's PO and make sure they're aware of the urgency. | ||
- Do PRs exist for these changes? | ||
- [ ] If so, have they been approved? | ||
|
||
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase. | ||
|
||
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,3 @@ module.exports = { | |
path.join(__dirname, './test/jest/setupFiles.js'), | ||
], | ||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Empty file.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.