UIQM-743: Prevent handleSubmit from running if there is any validation issue, instead of using the complete form API.

[Dmytro-Melnyshyn]

Purpose

Be able to see a modal window after canceling a record, if there are changes in it.

Issues

UIQM-743

Approach

Prevent handleSubmit from running once there is any validation issue instead of using the complete form API, since the form sets submitSucceeded to true and that flag is responsible for showing the confirmation modal. This also removes duplication.

Screencasts

2024-12-27_17h43_16.mp4

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

• I've added appropriate record to the CHANGELOG.md
• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all they appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[github-actions]

Jest Unit Test Results

  1 files  ±0   45 suites  ±0   2m 39s ⏱️ -1s
481 tests  - 2  481 ✅  - 2  0 💤 ±0  0 ❌ ±0 
484 runs   - 2  484 ✅  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit 2a87eba. ± Comparison against base commit 93f9961.

This pull request removes 3 and adds 1 tests. Note that renamed tests count towards both.

useSaveRecord when creating when there is a validation error should stop submitting ‑ useSaveRecord when creating when there is a validation error should stop submitting
useSaveRecord when deriving when there is a validation error should stop submitting ‑ useSaveRecord when deriving when there is a validation error should stop submitting
useSaveRecord when editing when there is a validation error should stop submitting ‑ useSaveRecord when editing when there is a validation error should stop submitting

Given QuickMarcEditor when saving form with validation issue should prevent submitting ‑ Given QuickMarcEditor when saving form with validation issue should prevent submitting

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud