UIQM-740 Don't show warn/fail error toasts when there are no warns/fails. #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zburke
approved these changes
Dec 2, 2024
| @@ -895,6 +895,30 @@ describe('Given QuickMarcEditor', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('when saving form without validation warnings or errors', () => { | |||
There was a problem hiding this comment.
Suggested change
| describe('when saving form without validation warnings or errors', () => { | |
| describe('when saving form without validation warnings and errors', () => { |
There was a problem hiding this comment.
In English you can say "without X or Y" meaning "without X and without Y". A little weird, but that's how it is.
Interestingly, it works the same way as De Morgan's law in boolean logic, where "not (A or B) = (not A) and (not B)"
There was a problem hiding this comment.
Wow, I haven't thought about De Morgan since grad school!
| await fireEvent.click(getByText('stripes-acq-components.FormFooter.save')); | ||
| }); | ||
|
|
||
| it('should show a toast notification about validation warning and error', async () => { |
There was a problem hiding this comment.
Suggested change
| it('should show a toast notification about validation warning and error', async () => { | |
| it('should not show a toast notification about validation warning and error', async () => { |
|
zburke
approved these changes
Dec 3, 2024
Dmytro-Melnyshyn
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't show warn/fail error toasts when there are no warns/fails.
Screenshots
chrome_MovqHmrwMJ.mp4
Issues
UIQM-740