-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIQM-730 Create/Edit/Derive MARC record - Retain focus when MARC record validation rules error display. Show validation issues toasts. #755
Conversation
…rd validation rules error display. Show validation issues toasts.
Jest Unit Test Results 1 files ±0 45 suites - 1 2m 19s ⏱️ -15s Results for commit dd7e1ce. ± Comparison against base commit 9c8f180. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
db8eb43
to
a60a27e
Compare
a60a27e
to
2c6bd0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM but I'd like to tweak the language in the toasts a little bit. Sorry, I was a copy editor in college and the job still haunts me. 👻
translations/ui-quick-marc/en.json
Outdated
"record.save.error.warn": "<b>Please scroll to view the entire record. Resolve errors as needed and save to revalidate the record.</b>{breakingLine}Warn errors: <b>{warnCount}</b>", | ||
"record.save.error.fail": "<b>Please scroll to view the entire record. Resolve errors as needed and save to revalidate the record.</b>{breakingLine}Fail errors: <b>{failCount}</b>{breakingLine}Record cannot be saved with a fail error.", | ||
"record.save.error.failAndWarn": "<b>Please scroll to view the entire record. Resolve errors as needed and save to revalidate the record.</b>{breakingLine}Warn errors: <b>{warnCount}</b>{breakingLine}Fail errors: <b>{failCount}</b>{breakingLine}Record cannot be saved with a fail error.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/warn errors/warnings/
: warnings are notifications that something is not quite right, but validation will still succeed. A record with warnings can be saved.s/fail errors/errors/
: an error means validation failed. A record with errors cannot be saved. Alternative to "errors": "failures", but I think "errors" is more common.
Maybe use language like, "Resolve issues as needed..." since "issues" can cover both "warnings" and "errors"?
Quality Gate passedIssues Measures |
Description
Create/Edit/Derive MARC record - Retain focus when MARC record validation rules error display.
Show validation issues toasts.
Screenshots
Issues
UIQM-730