UIQM-724 do not group together subfields during linking #750
Conversation
|
|
||
| const isSubfieldControlled = (subfieldLetter) => { | ||
| return linkingRule.authoritySubfields.includes(subfieldLetter) | ||
| || linkingRule.subfieldModifications.find(mod => mod.target === subfieldLetter); |
There was a problem hiding this comment.
subfieldModifications is not always present in linking rules, let's add optional chaining.
There was a problem hiding this comment.
@Dmytro-Melnyshyn I've checked the response and rules that don't have modifications still have an empty array
There was a problem hiding this comment.
It's weird that this field isn't everywhere at bugfest.
There was a problem hiding this comment.
@Dmytro-Melnyshyn asked Pavlo about it and it's because of a json serializer update, in Ramsons we can expect to always have subfieldModifications
| autoLinkingEnabled: true, | ||
| }, { | ||
| id: 12, | ||
| bibField: '650', | ||
| authorityField: '150', | ||
| authoritySubfields: ['a', 'b', 'g'], | ||
| subfieldModifications: [], |
There was a problem hiding this comment.
Let's remove it for at least one rule to catch the error in tests, since subfieldModifications is not present in all rules.
| bibField.prevContent = bibField.content; | ||
| bibField.content = joinSubfields(updatedBibSubfields); | ||
| bibField.content = updatedBibSubfields.join(); |
There was a problem hiding this comment.
I wonder if it would be better to avoid pretending to be array methods. This implementation looks cool, but is confusing because it is not an array, but uses join, which is actually reduce.
|
Description
Fix issue with grouped subfields during linking. Issue is caused by using
getContentSubfieldValuewhich iterates over parsed contents and returns an object with key-value pair where a key is a subfield code, and value is an array of subfield values from that code. Therefore, we're losing the order of subfields.Instead added a new utility
getContentSubfieldValueArrwhich returns an array of objects with a single subfield code and value, therefore keeping the original order of subfields, and a new classMarcFieldContent.This class encapsulates some common logic when working with subfields during linking: getting a subfield value, adding a subfield, removing a subfield, joining subfields etc.
Screenshots
chrome_YHbEAULZVE.mp4
Issues
UIQM-724