Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-715: Reuse existing ids for fields after saving a record to avoid re-rendering and be able to focus on a field by ref. #749

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Oct 22, 2024

Purpose

Move focus to the last focused field after saving a record.

Approach

Ids of fields are generated again after the record is saved, this creates new elements for each field and prevents the use of ref to focus the element. The approach is to reuse existing ids.

TODOS and Open Questions

Issues

UIQM-715

Screencasts

2024-10-22_17h25_50.mp4

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

…d re-rendering and be able to focus on a field by ref.
Copy link

github-actions bot commented Oct 22, 2024

Jest Unit Test Results

  1 files  ±0   47 suites  ±0   2m 51s ⏱️ +4s
475 tests +2  475 ✅ +2  0 💤 ±0  0 ❌ ±0 
478 runs  +2  478 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit aeada80. ± Comparison against base commit 60749b5.

♻️ This comment has been updated with latest results.

Copy link

@mariia-aloshyna mariia-aloshyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix lint issues please

Copy link
Contributor

@BogdanDenis BogdanDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to fix ESlint issues

Copy link

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from mariia-aloshyna and a team October 24, 2024 06:25
@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 6c432d3 into master Oct 24, 2024
15 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIQM-715 branch October 24, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants