Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-712: In field 007 for Projected Graphic type: change the MfS field type to Byte to allow only 1 character to be entered. #745

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

Purpose

The MfS textbox in field 007 should allow entry of only one character.

Approach

Use SUBFIELD_TYPES.BYTE which is intended for this purpose.

Issues

UIQM-712

Screencast

2024-10-09_15h22_06.mp4

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

…ld type to Byte to allow only 1 character to be entered.
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team October 9, 2024 12:23
Copy link

github-actions bot commented Oct 9, 2024

Jest Unit Test Statistics

    1 files  ±0    47 suites  ±0   3m 0s ⏱️ -10s
473 tests ±0  473 ✔️ ±0  0 💤 ±0  0 ±0 
476 runs  ±0  476 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit dba8d79. ± Comparison against base commit 77ae919.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from UladzislauKutarkin, BogdanDenis and a team and removed request for a team October 10, 2024 07:13
Copy link

Jest Unit Test Results

  1 files  ±0   47 suites  ±0   2m 43s ⏱️ -6s
475 tests ±0  475 ✅ ±0  0 💤 ±0  0 ❌ ±0 
478 runs  ±0  478 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 952ed7b. ± Comparison against base commit d99cee5.

Copy link

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit f0f44a1 into master Oct 15, 2024
15 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIQM-712 branch October 15, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants