Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-709 Duplicate LCCN checking query > Do not return instance/bib record that is set for deletion #741

Closed
wants to merge 2 commits into from

Conversation

BogdanDenis
Copy link
Contributor

@BogdanDenis BogdanDenis commented Oct 3, 2024

Description

If an Instance found by 010$a is staff suppressed or discovery suppressed - then don't include this Instance when checking for LCCN duplicates

Issues

UIQM-709

This comment has been minimized.

Copy link

github-actions bot commented Oct 3, 2024

Jest Unit Test Statistics

    1 files  ±0    47 suites  ±0   2m 58s ⏱️ -12s
473 tests ±0  473 ✔️ ±0  0 💤 ±0  0 ±0 
476 runs  ±0  476 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a78bd3f. ± Comparison against base commit 30c579b.

♻️ This comment has been updated with latest results.

@BogdanDenis BogdanDenis force-pushed the UIQM-709 branch 2 times, most recently from 086c095 to da2582b Compare October 3, 2024 15:03
Copy link

sonarqubecloud bot commented Oct 4, 2024

@BogdanDenis BogdanDenis marked this pull request as ready for review October 4, 2024 15:00
@BogdanDenis BogdanDenis requested review from Dmytro-Melnyshyn and a team October 4, 2024 15:00
@@ -479,7 +480,7 @@ export const validateLccnDuplication = async ({

const searchParams = {
limit: 1,
query: `(${lccnQuery})${idQuery}`,
query: `(${lccnQuery})${idQuery} and (staffSuppress=="false" or discoverySuppress=="false")`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields are not present in authorities.

@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIQM-709 branch October 8, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants