Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-652 eliminate page refresh when using save and keep ediing [WIP] #740

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

BogdanDenis
Copy link
Contributor

Description

Currently when users use "Save & keep editing" we re-fetch data and update relatedRecordVersion in the URL. This causes page to refresh which is a jarring user experience.
This PR now uses QuickMarcContext to store the relatedRecordVersion which doesn't require a page reload to update.
Also we now keep the last input that was in focus before the Save, so when a record is saved successfully we can re-focus that input. (But for some reason Callout messages don't return the focus back when a notification disappears)

Screenshots

chrome_DiPCW8wYDI.mp4

Issues

UIQM-652

Copy link

github-actions bot commented Oct 3, 2024

Jest Unit Test Statistics

    1 files  ±0    47 suites  ±0   3m 12s ⏱️ +10s
472 tests  - 2  472 ✔️  - 2  0 💤 ±0  0 ±0 
475 runs   - 2  475 ✔️  - 2  0 💤 ±0  0 ±0 

Results for commit e90aa56. ± Comparison against base commit dcc6595.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 15, 2024

Jest Unit Test Results

  1 files  ±0   47 suites  ±0   2m 45s ⏱️ +2s
473 tests  - 2  473 ✅  - 2  0 💤 ±0  0 ❌ ±0 
476 runs   - 2  476 ✅  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit 8c51dab. ± Comparison against base commit f0f44a1.

This pull request removes 2 tests.
Given Quick Marc Editor Container when the action is CREATE should not append the relatedRecordVersion parameter to URL ‑ Given Quick Marc Editor Container when the action is CREATE should not append the relatedRecordVersion parameter to URL
Given Quick Marc Editor Container when the action is not CREATE should append the relatedRecordVersion parameter to URL ‑ Given Quick Marc Editor Container when the action is not CREATE should append the relatedRecordVersion parameter to URL

♻️ This comment has been updated with latest results.

@BogdanDenis BogdanDenis requested review from Dmytro-Melnyshyn and a team October 15, 2024 14:21
Copy link

@BogdanDenis BogdanDenis merged commit cdd7b54 into master Oct 16, 2024
15 checks passed
@BogdanDenis BogdanDenis deleted the UIQM-652 branch October 16, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants