Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-695: Remove extra $ from error messages when adding/removing $t from 1XX of linked MARC authority record. #731

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

Purpose

Remove the extra $ sign in error messages.

Issues

UIQM-695

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@Dmytro-Melnyshyn Dmytro-Melnyshyn changed the title UIQM-695: Remove extra $ from error messages when adding/removing from 1XX of linked MARC authority record. UIQM-695: Remove extra $ from error messages when adding/removing $t from 1XX of linked MARC authority record. Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

Jest Unit Test Statistics

    1 files  ±0    47 suites  ±0   3m 17s ⏱️ +19s
469 tests ±0  469 ✔️ ±0  0 💤 ±0  0 ±0 
472 runs  ±0  472 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7465d6b. ± Comparison against base commit 09ac535.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from BogdanDenis and a team September 19, 2024 09:00
Copy link

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team September 20, 2024 09:31
@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 99e7a28 into master Sep 20, 2024
5 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIQM-695 branch September 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants