UIQM-697: Field 008: Validate the length of subfields. Add backslashes if the length of a subfield of field 008 is shorter, if longer - cut off the extra characters.

CHANGELOG.md

@@ -26,6 +26,7 @@
 * [UIQM-691](https://issues.folio.org/browse/UIQM-691) Show correct field and toast color when validation returns warnings.
 * [UIQM-665](https://issues.folio.org/browse/UIQM-665) Fix to generate array content in 008 after changing document type of MARC bib.
 * [UIQM-694](https://issues.folio.org/browse/UIQM-694) Separate error messages triggered by controlled subfields of different linked fields.
+* [UIQM-697](https://issues.folio.org/browse/UIQM-697) Field 008: Validate the length of subfields. Add backslashes if the length of a subfield of field 008 is shorter, if longer - cut off the extra characters.
 
 ## [8.0.1] (https://github.com/folio-org/ui-quick-marc/tree/v8.0.1) (2024-04-18)
 

src/QuickMarcEditor/QuickMarcCreateWrapper.test.js

@@ -28,6 +28,7 @@ import {
   holdingsLeader,
 } from '../../test/jest/fixtures/leaders';
 import fixedFieldSpecBib from '../../test/mocks/fixedFieldSpecBib';
+import fixedFieldSpecAuth from '../../test/mocks/fixedFieldSpecAuth';
 
 const runWithDelayedPromise = (fn, delay) => () => {
   return new Promise(resolve => setTimeout(() => resolve(fn()), delay));
@@ -118,7 +119,7 @@ const mockRecords = {
         'Type': 'a',
         'BLvl': 'm',
         'Desc': 'c',
-        'Entered': '211212',
+        'Entered': '21121',
         'DtSt': '|',
         'Date1': '2016',
         'Date2': '||||',
@@ -232,6 +233,11 @@ const mockFormValues = jest.fn((marcType) => ({
   updateInfo: { recordState: 'NEW' },
 }));
 
+const mockSpecs = {
+  [MARC_TYPES.BIB]: fixedFieldSpecBib,
+  [MARC_TYPES.AUTHORITY]: fixedFieldSpecAuth,
+};
+
 jest.mock('@folio/stripes/final-form', () => () => (Component) => ({
   onSubmit,
   marcType,
@@ -311,7 +317,7 @@ const renderQuickMarcCreateWrapper = ({
       mutator={mutator}
       action={QUICK_MARC_ACTIONS.CREATE}
       marcType={marcType}
-      fixedFieldSpec={fixedFieldSpecBib}
+      fixedFieldSpec={mockSpecs[marcType]}
       initialValues={mockFormValues(marcType)}
       locations={locations}
     />

src/QuickMarcEditor/QuickMarcDeriveWrapper.test.js

@@ -73,7 +73,7 @@ const mockFormValues = jest.fn(() => ({
         Cont: ['b', '\\', '\\', '\\'],
         Ctry: 'miu',
         Date1: '2009',
-        Date2: '\\\\',
+        Date2: '\\\\\\\\',
         Desc: 'i',
         DtSt: 's',
         Entered: '130325',

src/QuickMarcEditor/QuickMarcEditWrapper.test.js

@@ -24,6 +24,7 @@ import {
   bibLeaderString,
 } from '../../test/jest/fixtures/leaders';
 import fixedFieldSpecBib from '../../test/mocks/fixedFieldSpecBib';
+import fixedFieldSpecAuth from '../../test/mocks/fixedFieldSpecAuth';
 
 jest.mock('./utils', () => ({
   ...jest.requireActual('./utils'),
@@ -68,7 +69,7 @@ const mockRecords = {
       'content': {
         'Type': 'a',
         'BLvl': 'm',
-        'Entered': '240404',
+        'Entered': '24040',
         'DtSt': 'u',
         'Date1': '\\\\\\\\',
         'Date2': '\\\\\\\\',
@@ -277,6 +278,11 @@ const mockFormValues = jest.fn((marcType) => ({
   updateInfo: { recordState: 'NEW' },
 }));
 
+const mockSpecs = {
+  [MARC_TYPES.BIB]: fixedFieldSpecBib,
+  [MARC_TYPES.AUTHORITY]: fixedFieldSpecAuth,
+};
+
 const mockActualizeLinks = jest.fn((formValuesToProcess) => Promise.resolve(formValuesToProcess));
 const mockUpdateMarcRecord = jest.fn().mockResolvedValue();
 const mockOnCheckCentralTenantPerm = jest.fn().mockReturnValue(false);
@@ -383,7 +389,7 @@ const renderQuickMarcEditWrapper = ({
           locations={locations}
           externalRecordPath="/some-record"
           refreshPageData={jest.fn().mockResolvedValue()}
-          fixedFieldSpec={fixedFieldSpecBib}
+          fixedFieldSpec={mockSpecs[marcType]}
           onCheckCentralTenantPerm={mockOnCheckCentralTenantPerm}
           {...renderProps}
           {...props}
@@ -513,7 +519,7 @@ describe('Given QuickMarcEditWrapper', () => {
                 'Date1': '\\\\\\\\',
                 'Date2': '\\\\\\\\',
                 'DtSt': 'u',
-                'Entered': '240404',
+                'Entered': '24040',
                 'Fest': '1',
                 'Form': 's',
                 'GPub': 's',

src/hooks/useValidation/rules.js

@@ -26,6 +26,7 @@ import {
   validateContentExistence,
   validateFixedFieldPositions,
   validateLccnDuplication,
+  validateFixedFieldLength,
 } from './validators';
 import {
   is010LinkedToBibRecord,
@@ -52,6 +53,7 @@ const RULES = {
   SUBFIELD_VALUE_MATCH: validateSubfieldValueMatch,
   SUBFIELD_CHANGED: validateSubfieldChanged,
   FIXED_FIELD_POSITIONS: validateFixedFieldPositions,
+  FIXED_FIELD_LENGTH: validateFixedFieldLength,
   DUPLICATE_LCCN: validateLccnDuplication,
 };
 
@@ -84,6 +86,11 @@ const BASE_BIB_VALIDATORS = [
     validator: RULES.FIXED_FIELD_POSITIONS,
     message: (name) => ({ id: 'ui-quick-marc.record.error.008.invalidValue', values: { name } }),
   },
+  {
+    tag: '008',
+    validator: RULES.FIXED_FIELD_LENGTH,
+    message: (name, length) => ({ id: 'ui-quick-marc.record.error.008.invalidLength', values: { name, length } }),
+  },
   {
     validator: RULES.$9IN_LINKABLE,
     message: () => ({ id: 'ui-quick-marc.record.error.$9' }),
@@ -258,6 +265,11 @@ const BASE_AUTHORITY_VALIDATORS = [
     validator: RULES.DUPLICATE_LCCN,
     message: () => ({ id: 'ui-quick-marc.record.error.010.lccnDuplicated' }),
   },
+  {
+    tag: '008',
+    validator: RULES.FIXED_FIELD_LENGTH,
+    message: (name, length) => ({ id: 'ui-quick-marc.record.error.008.invalidLength', values: { name, length } }),
+  },
 ];
 
 const CREATE_AUTHORITY_VALIDATORS = [

src/hooks/useValidation/useValidation.js

@@ -2,6 +2,7 @@ import {
   useCallback,
   useContext,
 } from 'react';
+import { useIntl } from 'react-intl';
 import flow from 'lodash/flow';
 
 import { useOkapiKy } from '@folio/stripes/core';
@@ -13,6 +14,7 @@ import {
   useValidate,
 } from '../../queries';
 import {
+  getLeaderPositions,
   isLeaderRow,
   joinErrors,
 } from '../../QuickMarcEditor/utils';
@@ -21,7 +23,11 @@ import {
   MISSING_FIELD_ID,
   SEVERITY,
 } from './constants';
-import { QUICK_MARC_ACTIONS } from '../../QuickMarcEditor/constants';
+import {
+  FIXED_FIELD_TAG,
+  QUICK_MARC_ACTIONS,
+} from '../../QuickMarcEditor/constants';
+import { FixedFieldFactory } from '../../QuickMarcEditor/QuickMarcEditorRows/FixedField';
 
 const BE_VALIDATION_MARC_TYPES = [MARC_TYPES.BIB, MARC_TYPES.AUTHORITY];
 
@@ -46,6 +52,7 @@ const useValidation = (context = {}) => {
   const { validate: validateFetch } = useValidate();
   const { duplicateLccnCheckingEnabled } = useLccnDuplicateConfig({ marcType: context.marcType });
   const ky = useOkapiKy();
+  const intl = useIntl();
 
   const runFrontEndValidation = useCallback(async (marcRecords) => {
     const validationRules = validators[context.marcType][context.action];
@@ -56,11 +63,12 @@ const useValidation = (context = {}) => {
       marcRecords,
       duplicateLccnCheckingEnabled,
       ky,
+      intl,
     }, rule)))
       .then(errorsList => errorsList.reduce((joinedErrors, ruleErrors) => joinErrors(joinedErrors, ruleErrors), {}));
 
     return formatFEValidation(errors);
-  }, [context, quickMarcContext, duplicateLccnCheckingEnabled, ky]);
+  }, [context, quickMarcContext, duplicateLccnCheckingEnabled, ky, intl]);
 
   const formatBEValidationResponse = (response, marcRecords) => {
     if (!response.issues) {
@@ -103,7 +111,50 @@ const useValidation = (context = {}) => {
     return issues;
   }, [context.action, context.marcType]);
 
-  const runBackEndValidation = useCallback(async (marcRecords) => {
+  // if the length of a subfield of field 008 is shorter, then add backslashes,
+  // if longer, then cut off the extra characters.
+  const fillIn008FieldBlanks = useCallback((marcRecords) => {
+    if (![MARC_TYPES.BIB, MARC_TYPES.AUTHORITY].includes(context.marcType)) {
+      return marcRecords;
+    }
+
+    const { type, position7 } = getLeaderPositions(context.marcType, marcRecords);
+    const fixedFieldType = FixedFieldFactory.getFixedFieldType(context.fixedFieldSpec, type, position7);
+
+    const fieldsMap = fixedFieldType.items
+      .filter(field => !field.isArray)
+      .reduce((acc, field) => ({ ...acc, [field.code]: field }), {});
+
+    return marcRecords.map(field => {
+      if (field.tag !== FIXED_FIELD_TAG) {
+        return field;
+      }
+
+      // if the spec contains a subfield length of 4, then '123456' becomes '1234' and '12' becomes '12\\\\'
+      return {
+        ...field,
+        content: Object.keys(field.content).reduce((acc, code) => {
+          const value = field.content[code];
+
+          if (Array.isArray(value) || !fieldsMap[code]) {
+            acc[code] = value;
+          } else {
+            const length = fieldsMap[code].length;
+
+            acc[code] = value.length === length
+              ? value
+              : value.substring(0, length).padEnd(length, '\\');
+          }
+
+          return acc;
+        }, {}),
+      };
+    });
+  }, [context.fixedFieldSpec, context.marcType]);
+
+  const runBackEndValidation = useCallback(async (records) => {
+    const marcRecords = fillIn008FieldBlanks(records);
+
     const body = {
       fields: marcRecords.filter(record => !isLeaderRow(record)),
       leader: marcRecords.find(isLeaderRow)?.content,
@@ -116,7 +167,7 @@ const useValidation = (context = {}) => {
       () => formatBEValidationResponse(response, marcRecords),
       removeError001MissingField,
     )();
-  }, [context, validateFetch, removeError001MissingField]);
+  }, [context, validateFetch, removeError001MissingField, fillIn008FieldBlanks]);
 
   const isBackEndValidationMarcType = useCallback(marcType => BE_VALIDATION_MARC_TYPES.includes(marcType), []);