-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIQM-571 Wait for PUT request to finish after deriving before redirecting to Inventory #616
Conversation
@@ -119,8 +119,6 @@ const QuickMarcDeriveWrapper = ({ | |||
|
|||
return mutator.quickMarcEditMarcRecord.POST(formValuesForDerive) | |||
.then(async ({ qmRecordId }) => { | |||
onClose('id'); // https://issues.folio.org/browse/UIQM-82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the third pane should display a loading indicator, until PUT returns a response ("Show an empty third pane with a loading indicator").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try to pass a flag for the third pane and show loading based on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct, I've reverted that change and fixed not returned Promise in saveLinksToNewRecord
function. Previously onClose
was called before that function has completed
…ting to Inventory
Kudos, SonarCloud Quality Gate passed! 0 Bugs 100.0% Coverage The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Description
Wait for PUT request to finish after deriving before redirecting to Inventory
onClose('id')
was added in #583, but now we're removingshared
parameter inonClose
in ui-inventory, so the issue is not reproducedScreenshots
chrome_KVSt14DSTb.mp4
Issues
UIQM-571