Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-571 Wait for PUT request to finish after deriving before redirecting to Inventory #616

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

BogdanDenis
Copy link
Contributor

Description

Wait for PUT request to finish after deriving before redirecting to Inventory

onClose('id') was added in #583, but now we're removing shared parameter in onClose in ui-inventory, so the issue is not reproduced

Screenshots

chrome_KVSt14DSTb.mp4

Issues

UIQM-571

@github-actions
Copy link

github-actions bot commented Oct 31, 2023

Jest Unit Test Statistics

    1 files  ±0    40 suites  ±0   2m 22s ⏱️ +40s
330 tests ±0  330 ✔️ ±0  0 💤 ±0  0 ±0 
331 runs  ±0  331 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 3faa22c. ± Comparison against base commit da3e996.

♻️ This comment has been updated with latest results.

@@ -119,8 +119,6 @@ const QuickMarcDeriveWrapper = ({

return mutator.quickMarcEditMarcRecord.POST(formValuesForDerive)
.then(async ({ qmRecordId }) => {
onClose('id'); // https://issues.folio.org/browse/UIQM-82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality initially was added in UIQM-82. I think the PO should be informed about this change.

onClose('id') was added to remove duplication and have one source of truth in ui-inventory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the third pane should display a loading indicator, until PUT returns a response ("Show an empty third pane with a loading indicator").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try to pass a flag for the third pane and show loading based on it.

Copy link
Contributor Author

@BogdanDenis BogdanDenis Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct, I've reverted that change and fixed not returned Promise in saveLinksToNewRecord function. Previously onClose was called before that function has completed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@BogdanDenis BogdanDenis merged commit 45d0972 into master Oct 31, 2023
4 checks passed
@BogdanDenis BogdanDenis deleted the UIQM-571 branch October 31, 2023 13:30
BogdanDenis added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants