UIQM-580: Move QuickMarcView, PrintPopup, useAuthorityLinkingRules and getHeaders to stripes-marc-components. #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmytro-Melnyshyn
force-pushed
the
UIQM-580
branch
from
c051337 to
d9d6fa2
Compare
Dmytro-Melnyshyn
changed the title
Dmytro-Melnyshyn
force-pushed
the
UIQM-580
branch
from
d9d6fa2 to
d7575f8
Compare
BogdanDenis
approved these changes
Oct 25, 2023
BogdanDenis
requested changes
Oct 26, 2023
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@folio/quick-marc", | |||
| "version": "7.0.1", | |||
| "version": "7.1.0", | |||
There was a problem hiding this comment.
Please bump up major version and add a Breaking change note in changelog
BogdanDenis
approved these changes
Oct 26, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Move
QuickMarcView,PrintPopup,useAuthorityLinkingRulesandgetHeaderstostripes-marc-components.Issues
UIQM-580
Related PRs
folio-org/stripes-marc-components#4
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.