UIQM-649 Added validation rule to prevent deletion of 010 when it is …

…a linking point. (#675)
folio-org · Apr 18, 2024 · 4fbcb05 · 4fbcb05
1 parent c023a1e
commit 4fbcb05
Show file tree

Hide file tree

Showing 3 changed files with 122 additions and 53 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 * [UIQM-641](https://issues.folio.org/browse/UIQM-641) Call `cleanBytesFields` function with correct arguments to fix 008 field.
 * [UIQM-640](https://issues.folio.org/browse/UIQM-640) Create authority | Make list of authority files in lookup alphabetical.
 * [UIQM-650](https://issues.folio.org/browse/UIQM-650) Use `setTimeout` to defer the execution of `showCallout` to ensure the toasts are shown after the potentially heavy render.
+* [UIQM-649](https://issues.folio.org/browse/UIQM-649) Added validation rule to prevent deletion of 010 when it is a linking point.
 
 ## [8.0.0](https://github.com/folio-org/ui-quick-marc/tree/v8.0.0) (2024-03-21)
 

diff --git a/src/hooks/useValidation/rules.js b/src/hooks/useValidation/rules.js
@@ -204,6 +204,12 @@ const BASE_AUTHORITY_VALIDATORS = [
     validator: RULES.SUBFIELD_VALUE_EXISTS,
     message: () => <FormattedMessage id="ui-quick-marc.record.error.010.$aRemoved" />,
   },
+  {
+    tag: '010',
+    ignore: ({ initialValues, naturalId }) => !is010LinkedToBibRecord(initialValues.records, naturalId),
+    validator: RULES.EXISTS,
+    message: () => <FormattedMessage id="ui-quick-marc.record.error.010.removed" />,
+  },
   {
     tag: '010',
     validator: RULES.NON_REPEATABLE,

diff --git a/src/hooks/useValidation/useValidation.test.js b/src/hooks/useValidation/useValidation.test.js
@@ -918,7 +918,7 @@ describe('useValidation', () => {
     });
   });
 
-  describe('when record is MARC Authority record', () => {
+  describe('when validating Authority record', () => {
     const localSourceFile = {
       id: '1',
       source: 'local',
@@ -1328,59 +1328,121 @@ describe('useValidation', () => {
           });
         });
 
-        describe('when 010 was removed', () => {
-          it('should not return an error message', () => {
-            const _initialValues = {
-              leader: initialValues.leader,
-              records: [
-                {
-                  id: 1,
-                  content: initialValues.leader,
-                  tag: 'LDR',
-                },
-                {
-                  id: 2,
-                  content: {},
-                  tag: '008',
-                },
-                {
-                  id: 3,
-                  tag: '110',
-                  content: '$a Record title',
-                },
-                {
-                  id: 4,
-                  tag: '010',
-                  content: '$a n123456',
-                },
-              ],
-            };
-            const { result } = renderHook(() => useValidation({
-              ...marcContext,
-              initialValues: _initialValues,
-            }));
-
-            const record = {
-              ...initialValues,
-              records: [
-                {
-                  id: 'LDR',
-                  content: initialValues.leader,
-                  tag: 'LDR',
-                },
-                {
-                  id: 1,
-                  content: {},
-                  tag: '008',
-                },
-                {
-                  id: 3,
-                  tag: '110',
-                },
-              ],
-            };
+        describe('when 010 was a linking point', () => {
+          describe('and 010 was removed', () => {
+            it('should return an error message', () => {
+              const _initialValues = {
+                leader: initialValues.leader,
+                records: [
+                  {
+                    id: 1,
+                    content: initialValues.leader,
+                    tag: 'LDR',
+                  },
+                  {
+                    id: 2,
+                    content: {},
+                    tag: '008',
+                  },
+                  {
+                    id: 3,
+                    tag: '110',
+                    content: '$a Record title',
+                  },
+                  {
+                    id: 4,
+                    tag: '010',
+                    content: '$a n123456',
+                  },
+                ],
+              };
+              const { result } = renderHook(() => useValidation({
+                ...marcContext,
+                initialValues: _initialValues,
+                naturalId: 'n123456',
+              }));
+
+              const record = {
+                ...initialValues,
+                records: [
+                  {
+                    id: 'LDR',
+                    content: initialValues.leader,
+                    tag: 'LDR',
+                  },
+                  {
+                    id: 1,
+                    content: {},
+                    tag: '008',
+                  },
+                  {
+                    id: 3,
+                    tag: '110',
+                  },
+                ],
+              };
+
+              expect(result.current.validate(record.records).props.id).toBe('ui-quick-marc.record.error.010.removed');
+            });
+          });
+        });
 
-            expect(result.current.validate(record.records)).toBeUndefined();
+        describe('when 010 was not a linking point', () => {
+          describe('and 010 was removed', () => {
+            it('should not return an error message', () => {
+              const _initialValues = {
+                leader: initialValues.leader,
+                records: [
+                  {
+                    id: 1,
+                    content: initialValues.leader,
+                    tag: 'LDR',
+                  },
+                  {
+                    id: 2,
+                    content: {},
+                    tag: '008',
+                  },
+                  {
+                    id: 3,
+                    tag: '110',
+                    content: '$a Record title',
+                  },
+                  {
+                    id: 4,
+                    tag: '010',
+                    content: '$a n123456',
+                  },
+                ],
+              };
+              const { result } = renderHook(() => useValidation({
+                ...marcContext,
+                initialValues: _initialValues,
+                naturalId: 'n09876',
+              }));
+
+              const record = {
+                ...initialValues,
+                records: [
+                  {
+                    id: 'LDR',
+                    content: initialValues.leader,
+                    tag: 'LDR',
+                  },
+                  {
+                    id: 1,
+                    content: {},
+                    tag: '008',
+                  },
+                  {
+                    id: 3,
+                    tag: '110',
+                  },
+                ],
+              };
+
+              expect(result.current.validate(record.records)).toBeUndefined();
+            });
           });
         });
       });