Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPQB-164: Columns are reset when user modifies query #202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

UladzislauKutarkin
Copy link
Contributor

https://folio-org.atlassian.net/browse/UIPQB-164

Here we added logic to save selected columns and update new ones after the edit query.

Screen.Recording.2024-12-24.at.15.06.02.mov

@UladzislauKutarkin UladzislauKutarkin requested review from vashjs and a team December 24, 2024 11:11
Copy link

github-actions bot commented Dec 24, 2024

Jest Unit Test Results

  1 files  ±0   12 suites  ±0   1m 25s ⏱️ -2s
126 tests ±0  125 ✅ ±0  1 💤 ±0  0 ❌ ±0 
130 runs  ±0  129 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 51efd2f. ± Comparison against base commit f97fb60.

♻️ This comment has been updated with latest results.

@@ -82,6 +82,7 @@ export const ResultViewer = ({
onPreviewShown,
defaultLimit,
forcedVisibleValues,
visibleColumns

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix eslint warnings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants