UIOR-1330: ECS - Holdings are not displayed correctly in POL locations accordion after updating the ownership of one of the holdings #1666
Conversation
…s accordion after updating the ownership of one of the holdings
src/common/hooks/useOrderLineLocations/useOrderLineLocations.js
Outdated
Show resolved
Hide resolved
src/common/hooks/useOrderLineLocationsByTenants/useOrderLineLocationsByTenants.js
Outdated
Show resolved
Hide resolved
src/common/hooks/useOrderLineLocationsByTenants/useOrderLineLocationsByTenants.js
Outdated
Show resolved
Hide resolved
| @@ -117,7 +130,7 @@ const LocationView = ({ | |||
| { | |||
| lineLocations.map((location, i) => ( | |||
| <Location | |||
| key={location.id || i} // i is required when new row of Location is added by User | |||
| key={location.holdingId || i} // i is required when new row of Location is added by User | |||
There was a problem hiding this comment.
I have checked the obeject dosn't provide id it provides holdingId instead
There was a problem hiding this comment.
There was a problem hiding this comment.
this is related to poline locations https://s3.amazonaws.com/foliodocs/api/mod-orders/p/order-lines.html#
"properties": {
"locationId": {
"description": "UUID of the (inventory) location record",
"type": "string",
"pattern": "^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[1-5][0-9a-fA-F]{3}-[89abAB][0-9a-fA-F]{3}-[0-9a-fA-F]{12}$"
},
"holdingId": {
"description": "Holding UUID associated with order line",
"type": "string",
"$schema": "http://json-schema.org/draft-04/schema#",
"pattern": "^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[1-5][0-9a-fA-F]{3}-[89abAB][0-9a-fA-F]{3}-[0-9a-fA-F]{12}$"
},
"quantity": {
"description": "Combined/total quanitity of physical and electronic items",
"type": "integer"
},
"quantityElectronic": {
"description": "Quantity of electronic items",
"type": "integer"
},
"quantityPhysical": {
"description": "Quantity of physical items",
"type": "integer"
},
"tenantId": {
"description": "Associated tenant for ECS-enabled clusters",
"type": "string"
}
},
```
There was a problem hiding this comment.
LocationsView <- POLineView <- POLine
There was a problem hiding this comment.
Oh, I look at another locations...
There was a problem hiding this comment.
Yes, you're right. But in that case it could be either holdingId or locationId
src/common/hooks/useLocationsAndHoldingsByTenants/useLocationsAndHoldingsByTenants.js
Outdated
Show resolved
Hide resolved
|
|
||
| const DEFAULT_DATA = []; | ||
|
|
||
| export const useLocationsAndHoldingsByTenants = ({ receivingTenantIdsByLocations = DEFAULT_DATA, instanceId }) => { |
There was a problem hiding this comment.
Let receivingTenantIdsByLocations be just tenantIds
|
|
No longer needed due the the issue has been fixed by back-end |
Purpose
UIOR-1330:- ECS - Holdings are not displayed correctly in POL locations accordion after updating the ownership of one of the holdings
Has corresponding ticket here folio-org/stripes-acq-components#824
Approach
Screen.Recording.2024-10-24.at.20.58.02.mp4
Screenshots
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.