UIIN-3106: Add 'linked-data' interface to 'optionalOkapiInterfaces' #2702
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkjacob
requested review from
zburke,
BogdanDenis,
mariia-aloshyna,
KaterynaSenchenko,
s3fs and
SKarolFolio
and removed request for
zburke
zburke
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM, though it's worth noting that the function leveraging this endpoint in ViewInstance.js is missing <IfInterface> protection, so it's nice that you're adding this declaration in package.json to include it in the module descriptor, but practically speaking the access is still unchecked and this is effectively a required interface.
BogdanDenis
requested changes
Dec 19, 2024
pkjacob
force-pushed
the
pjacob/UIIN-3106
branch
from
97af816 to
edf85ac
Compare
|
@BogdanDenis Change log added. |
BogdanDenis
approved these changes
Dec 20, 2024
pkjacob
force-pushed
the
pjacob/UIIN-3106
branch
from
edf85ac to
ad57502
Compare
pkjacob
force-pushed
the
pjacob/UIIN-3106
branch
from
ad57502 to
6d8ce52
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Inventory UI makes API call to the following API in linked-data module
GET linked-data/inventory-instance/:{id}/import-supported
Per stripes documentation, the optional interfaces that UI module uses should be declared in
optionalOkapiInterfacessection of package.json file.Purpose of this PR is to update
optionalOkapiInterfacessection of the package.json with the following"linked-data": "1.0"