[UICAL-269] Migrate from self-contained typings to stripes-types (again) #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira UICAL-269
redo of #506
Purpose
Initially, we developed our own typings for the Stripes framework, to be used internally by ui-calendar. This was great when we were the only TypeScript module in the FOLIO ecosystem, however, that is no longer the case, and it does not make sense for
ui-calendar
to be the source of truth for Stripes typings.Approach
Types were moved to https://github.com/folio-org/stripes-types (over the past many months), where they can be contributed to and shared by all FOLIO developers.
Now that this central location exists, there's no reason for ui-calendar to contain the old types; in fact, they often caused conflicts when attempting to build a platform.
Note
This broke the build on the first attempt, due to what appeared to be a type error in
ui-calendar
. This, however, was hiding the real issue —ui-bulk-edit
contained old types which had some incorrect and missing information. Once folio-org/ui-bulk-edit#440 is merged, this issue will be resolved.Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondinglyN/A