Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UICAL-272: Added TitleManager component to views to add html page titles #502

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

danetsao
Copy link
Contributor

@danetsao danetsao commented Nov 3, 2023

Purpose

Approach

Refs

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added an appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally, all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of inter-module and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@danetsao danetsao requested a review from ncovercash November 3, 2023 21:24
Copy link

github-actions bot commented Nov 3, 2023

Jest Unit Test Statistics

    1 files  ±0    71 suites  ±0   5m 29s ⏱️ + 2m 34s
327 tests ±0  326 ✔️ ±0  1 💤 ±0  0 ±0 
354 runs  ±0  353 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 49ad867. ± Comparison against base commit 10bac7a.

♻️ This comment has been updated with latest results.

Copy link
Member

@ncovercash ncovercash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix imports and tests and you should be good!

src/views/CreateEditCalendarLayer.tsx Outdated Show resolved Hide resolved
src/views/AllCalendarView.tsx Outdated Show resolved Hide resolved
src/views/CurrentAssignmentView.tsx Outdated Show resolved Hide resolved
src/views/CurrentAssignmentView.tsx Outdated Show resolved Hide resolved
@danetsao danetsao marked this pull request as ready for review November 6, 2023 22:22
@danetsao danetsao requested review from ncovercash and nhanaa November 6, 2023 22:23
Copy link

sonarqubecloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

74.5% 74.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@danetsao danetsao merged commit 291a165 into master Nov 28, 2023
3 of 4 checks passed
@ncovercash ncovercash deleted the UICAL-272 branch October 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants