Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UICAL-271: Update Node.js to v18 in GitHub Actions #495

Merged
merged 5 commits into from
Sep 21, 2023
Merged

UICAL-271: Update Node.js to v18 in GitHub Actions #495

merged 5 commits into from
Sep 21, 2023

Conversation

danetsao
Copy link
Contributor

Ref UICAL-271.

@danetsao danetsao requested a review from ncovercash September 14, 2023 15:22
@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  +    1    71 suites  +71   4m 1s ⏱️ + 4m 1s
331 tests +331  330 ✔️ +330  1 💤 +1  0 ❌ ±0 
358 runs  +358  357 ✔️ +357  1 💤 +1  0 ❌ ±0 

Results for commit 5e8dd66. ± Comparison against base commit 64c4230.

♻️ This comment has been updated with latest results.

@danetsao danetsao requested a review from nhanaa September 14, 2023 15:29
@ncovercash
Copy link
Member

ncovercash commented Sep 14, 2023 •
edited
Loading

@danetsao can you investigate these failing tests? not sure why it's complaining...maybe those can be circumvented wtih dayjs?.foo

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@danetsao danetsao merged commit 8b38be8 into master Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhanaa nhanaa nhanaa approved these changes

@ncovercash ncovercash ncovercash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danetsao @ncovercash @nhanaa