Changed conditional logic of '??' for null coalescence over '||'

folio-org · Nov 6, 2023 · 9d87b38 · 9d87b38
1 parent 79d1e80
commit 9d87b38
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/views/CurrentAssignmentView.tsx b/src/views/CurrentAssignmentView.tsx
@@ -34,7 +34,7 @@ export const CurrentAssignmentView: FunctionComponent<
   const history = useHistory();
   const currentRouteId = useRouteMatch<{ servicePointId: string }>(
     '/settings/calendar/active/:servicePointId'
-  )?.params?.servicePointId || '';
+  )?.params?.servicePointId ?? '';
 
   if (!dataRepository.isLoaded()) {
     return (
@@ -92,7 +92,7 @@ export const CurrentAssignmentView: FunctionComponent<
     };
   });
 
-  const calendarName = dataRepository.getCalendars().filter((c) => c.assignments.includes(currentRouteId))[0]?.name || '';
+  const calendarName = dataRepository.getCalendars().filter((c) => c.assignments.includes(currentRouteId))[0]?.name ?? '';
 
   const pageTitle = intl.formatMessage({ id: 'ui-calendar.meta.titleSettings' }) + ' - ' + intl.formatMessage({
     id: 'ui-calendar.currentAssignmentView.title'