UISAUTCOMP-135: useAutoOpenDetailView - block auto-open on mount if record id exists in URL.
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecord id exists in URL.
Dmytro-Melnyshyn
force-pushed
the
UISAUTCOMP-135
branch
from
598e494 to
7a24b8b
Compare
This comment has been minimized.
This comment has been minimized.
BogdanDenis
approved these changes
Dec 16, 2024
| @@ -49,6 +49,66 @@ describe('useAutoOpenDetailView hook', () => { | |||
| }); | |||
|
|
|||
| describe('when there is a record ID in URL', () => { | |||
| describe('and it is mount (page reload or redirection from quick marc)', () => { | |||
| it('should not open record`s detail view', async () => { | |||
There was a problem hiding this comment.
does this function require asynchronous operations?
There was a problem hiding this comment.
Looks like no, I'll remove it
mariia-aloshyna
approved these changes
Dec 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If there is an open record and the next search returns a single record, it is automatically opened in the third pane.
Approach
Currently: Block auto-opening of record if id is present in URL.
After this PR is merged: Block auto-opening of record if id is present in URL only on mount.
TODOS and Open Questions
Learning
Screenshots
2024-12-13_18h51_33.mp4