Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISAUTCOMP-133 Handle uncaught error when a search request fails. #174

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

BogdanDenis
Copy link
Contributor

Description

Handle uncaught error when a search request fails.

Screenshots

chrome_SS81mRIC7B.mp4

Issues

UISAUTCOMP-133

@BogdanDenis BogdanDenis requested review from Dmytro-Melnyshyn and a team November 27, 2024 16:42
Copy link

github-actions bot commented Nov 27, 2024

Jest Unit Test Statistics

179 tests  +1   179 ✔️ +1   1m 55s ⏱️ -2s
  33 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 5015eef. ± Comparison against base commit 00fdd65.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM but the tests are unhappy now 🤨

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@BogdanDenis BogdanDenis merged commit 26de19e into master Nov 28, 2024
5 of 6 checks passed
@BogdanDenis BogdanDenis deleted the UISAUTCOMP-133 branch November 28, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants