New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ui-quick-marc dependency #118

Merged

BogdanDenis merged 1 commit into master from remove-quick-marc-dep

Oct 13, 2023

Contributor

BogdanDenis commented Oct 13, 2023

There is a circular dependency between stripes-authority-components, ui-plugin-find-authority and ui-quick-marc which blocks releasing all three modules
ui-quick-marc depends on ui-plugin-find-authority, which depends on stripes-authority-components, which in turn has ui-quick-marc dependency.
Thankfully, ui-quick-marc is not used anywhere in code - it was just listed as a dep, so we only need to update package.json


          Remove ui-quick-marc dependency

98fc784

BogdanDenis requested a review from Dmytro-Melnyshyn

October 13, 2023 11:52

Dmytro-Melnyshyn approved these changes

View reviewed changes

github-actions bot commented Oct 13, 2023 •

edited

Loading

Jest Unit Test Statistics

150 tests ±0 150 ✔️ ±0 1m 16s ⏱️ -4s
  31 suites ±0     0 💤 ±0
    1 files ±0     0 ❌ ±0

Results for commit 98fc784. ± Comparison against base commit 9b6a207.

♻️ This comment has been updated with latest results.

sonarqubecloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

BogdanDenis merged commit 099d9f1 into master

6 checks passed

BogdanDenis deleted the remove-quick-marc-dep branch

October 13, 2023 11:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet