Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISACQCOMP-237 Exclude unsupported currencies #844

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

azizjonnurov
Copy link
Contributor

@azizjonnurov azizjonnurov commented Dec 24, 2024

Purpose

https://folio-org.atlassian.net/browse/UISACQCOMP-237

Approach

Screenshots

Screen.Recording.2024-12-24.at.18.30.24.mov

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@azizjonnurov azizjonnurov requested a review from a team as a code owner December 24, 2024 12:34
Copy link

github-actions bot commented Dec 24, 2024

Jest Unit Test Statistics

    1 files  ±0  235 suites  ±0   4m 9s ⏱️ - 1m 0s
627 tests +2  625 ✔️ +2  2 💤 ±0  0 ±0 
630 runs  +2  628 ✔️ +2  2 💤 ±0  0 ±0 

Results for commit edc3eaf. ± Comparison against base commit ebd6659.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 24, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit edc3eaf. ± Comparison against base commit ebd6659.

♻️ This comment has been updated with latest results.

@usavkov-epam
Copy link
Contributor

Please attach a screen recording with export proccess after fix

Copy link
Contributor

@usavkov-epam usavkov-epam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the type of exchangeRates before and after changes.

lib/utils/invoiceExport/getInvoiceExportData.js Outdated Show resolved Hide resolved
@usavkov-epam
Copy link
Contributor

Please update the PR title according to the convention

@azizjonnurov azizjonnurov changed the title UISACQCOMP-237 UISACQCOMP-237 Exclude unsupported currencies Dec 25, 2024
@azizjonnurov azizjonnurov requested review from usavkov-epam and a team December 25, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants