Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reusable claiming code from ui-receiving to the shared library #841

Merged
merged 13 commits into from
Dec 19, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Dec 17, 2024

Purpose

https://folio-org.atlassian.net/browse/UISACQCOMP-236

Typings PR: folio-org/stripes-types#74

Approach

Move from ui-receiving or implement (if doesn't exist) components for claiming:

  • <SendClaimActionMenuItem>
  • <SendClaimsModal>
  • <DelayClaimActionMenuItem>
  • <DelayClaimsModal>
  • <MarkUnreceivableActionMenuItem>
  • getClaimingIntervalFromDate
  • useClaimsDelay
  • useClaimsSend
  • usePiecesStatusBatchUpdate

Screenshot

chrome_M3FL3rlLuO.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

Jest Unit Test Statistics

    1 files  ±  0  235 suites  +10   4m 5s ⏱️ -2s
625 tests +23  623 ✔️ +23  2 💤 ±0  0 ±0 
628 runs  +23  626 ✔️ +23  2 💤 ±0  0 ±0 

Results for commit 977251a. ± Comparison against base commit 8b8428d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 977251a. ± Comparison against base commit 8b8428d.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam requested review from a team December 18, 2024 11:23
@usavkov-epam
Copy link
Contributor Author

@folio-org/fe-tl-reviewers please review

@usavkov-epam usavkov-epam merged commit 76fa627 into master Dec 19, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UISACQCOMP-236 branch December 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants