UISACQCOMP-228 Revert changes in useFilters hook #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alisher-epam
approved these changes
Nov 12, 2024
vashjs
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Hi @usavkov-epam I've approved, changes looks good to me.
But I think it would be nice to add ticket number in PR title to have links from jira + in description could you add PR where it was added initially, to have clear history.
usavkov-epam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://folio-org.atlassian.net/browse/UISACQCOMP-228?focusedCommentId=237472
regression of #829