Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UISACQCOMP-166: add unassignDonor to default formatters #728

Merged
merged 5 commits into from
Nov 10, 2023
Merged

UISACQCOMP-166: add unassignDonor to default formatters #728

merged 5 commits into from
Nov 10, 2023

Conversation

alisher-epam
Copy link
Contributor

@alisher-epam alisher-epam commented Nov 9, 2023 •
edited
Loading

Purpose

UISACQCOMP-166 - Updated default visible columns for the container. The purpose we don't need to pass the unassignDonor for form-based donors list. And move remove button on the right side of the row.

Approach

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0  146 suites  +1   4m 24s ⏱️ +30s
384 tests +2  383 ✔️ +2  1 💤 ±0  0 ❌ ±0 
386 runs  +2  385 ✔️ +2  1 💤 ±0  0 ❌ ±0 

Results for commit 2f71a3e. ± Comparison against base commit be0e6f9.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
getUnAssignDonorFormatter should return object with name, code and unassignDonor functions ‑ getUnAssignDonorFormatter should return object with name, code and unassignDonor functions

DonorsListContainer should render component ‑ DonorsListContainer should render component
DonorsListContainer should render loading component ‑ DonorsListContainer should render loading component
getDonorsFormatter should return object with name, code and unassignDonor functions ‑ getDonorsFormatter should return object with name, code and unassignDonor functions

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 2f71a3e. ± Comparison against base commit be0e6f9.

♻️ This comment has been updated with latest results.

@alisher-epam alisher-epam requested a review from a team November 9, 2023 10:57
usavkov-epam
usavkov-epam reviewed Nov 9, 2023
View reviewed changes
lib/Donors/DonorsList.js Outdated
}) => {
const stripes = useStripes();
const canViewOrganizations = stripes.hasPerm('ui-organizations.view');
const formatter = useMemo(() => {
return formatterProp || getDonorsListFormatter({ canViewOrganizations });
}, [canViewOrganizations, formatterProp]);

const anchoredRowFormatter = (rowProp) => acqRowFormatter(rowProp);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why create a function that doesn't do anything when you can pass in the original?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@alisher-epam alisher-epam merged commit 226aa07 into master Nov 10, 2023
5 checks passed
@alisher-epam alisher-epam deleted the UISACQCOMP-166 branch November 10, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usavkov-epam usavkov-epam usavkov-epam approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alisher-epam @BogdanDenis @usavkov-epam