refactor: fix code quality based on comments

folio-org · Sep 25, 2024 · 972efe2 · 972efe2
1 parent c34d15f
commit 972efe2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/lib/AffiliationsSelection/AffiliationsSelection.test.js b/lib/AffiliationsSelection/AffiliationsSelection.test.js
@@ -36,7 +36,7 @@ const renderAffiliationsSelection = (props = {}) => render(
 );
 
 describe('AffiliationsSelection', () => {
-  it('should render affiliation selection with provided options', async () => {
+  it('should render affiliation selection with provided options', () => {
     renderAffiliationsSelection();
 
     expect(

diff --git a/lib/FieldLocation/FieldLocationFinalContainer.test.js b/lib/FieldLocation/FieldLocationFinalContainer.test.js
@@ -32,23 +32,23 @@ const renderFieldLocationFinalContainer = (props = {}, formProps = {}) => (rende
 ));
 
 describe('FieldLocationFinalContainer component', () => {
-  beforeEach(() => {
-    renderFieldLocationFinalContainer();
+  it('should display passed label', () => {
+    renderFieldLocationFinalContainer({ labelId: 'Location' });
 
     const button = screen.getByText('stripes-components.selection.controlLabel');
 
     fireEvent.click(button);
-  });
-
-  it('should display passed label', () => {
-    renderFieldLocationFinalContainer({ labelId: 'Location' });
 
     expect(screen.getByText(fieldLocationLabel)).toBeDefined();
   });
 
   it('should render options based on passed locationIds', async () => {
     renderFieldLocationFinalContainer();
 
+    const button = screen.getByText('stripes-components.selection.controlLabel');
+
+    fireEvent.click(button);
+
     const renderedLocationOptions = await screen.findAllByText(/Location #[0-9]/);
 
     expect(renderedLocationOptions.length).toBe(locationsIds.length);
@@ -59,6 +59,10 @@ describe('FieldLocationFinalContainer component', () => {
       filterLocations: (records) => records.slice(0, 2),
     });
 
+    const button = screen.getByText('stripes-components.selection.controlLabel');
+
+    fireEvent.click(button);
+
     const renderedLocationOptions = await screen.findAllByText(/Location #[0-9]/);
 
     expect(renderedLocationOptions).toHaveLength(2);

diff --git a/lib/LanguageFilter/LanguageFilter.test.js b/lib/LanguageFilter/LanguageFilter.test.js
@@ -1,5 +1,4 @@
 import {
-  cleanup,
   fireEvent,
   render,
 } from '@testing-library/react';