Skip to content

Commit

Permalink
add changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
aliaksei-chumakou committed Dec 12, 2019
1 parent 36ca7e1 commit 94d0862
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 20 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# Change history for stripes-acq-components

## [1.3.1](https://github.com/folio-org/stripes-acq-components/tree/v1.3.1) (in progress)
[Full Changelog](https://github.com/folio-org/ui-invoice/compare/v1.3.0...v1.3.1)

### Stories
* [UIORGS-122](https://issues.folio.org/browse/UIORGS-122) Organization view pane: Update contact people view

### Bug Fixes
* [UIOR-464](https://issues.folio.org/browse/UIOR-464) Calculation of estimated price in cost details sometimes blocks POLs from being created/saved
* [UIPFPOL-3](https://issues.folio.org/browse/UIPFPOL-3) Return focus after lookup modal is closed without selection
* [ERM-620](https://issues.folio.org/browse/ERM-620) Agreement edit/new: return focus to the lookup button when a lookup modal is closed
* [UINV-94](https://issues.folio.org/browse/UINV-94) Not able to create invoice lines with $0 subtotal

## [1.3.0](https://github.com/folio-org/stripes-acq-components/tree/v1.3.0) (2019-12-04)
[Full Changelog](https://github.com/folio-org/stripes-acq-components/compare/v1.2.0...v1.3.0)

Expand Down
31 changes: 11 additions & 20 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
<!--
If you have a relevant JIRA issue number, please put it in the issue title.
Example: MODGOBI-43 Move "Renewals" information to Purchase Order level
TL;DR
- https://www.youtube.com/watch?v=5aHmO_S8FQ4
- http://www.olitreadwell.com/2016/05/22/how-to-write-great-pull-requests/
- https://www.atlassian.com/blog/git/written-unwritten-guide-pull-requests
Example: MODORDERS-70 Orders schema updates
-->

## Purpose
Expand All @@ -14,7 +9,7 @@
to provide to the reviewer and to future readers than the cause
that gave rise to this pull request. Be careful to avoid circular
statements like "the purpose is to update the schema." and
instead provide an explanation like "there is more data to be provided and stored for Purchase Orders
instead provide an explanation like "there is more data to be provided and stored for Purchase Orders
which is currently missing in the schema"
The purpose may seem self-evident to you now, but the standard to
Expand All @@ -23,7 +18,7 @@
section."
If you have a relevant JIRA issue, add a link directly to the issue URL here.
Example: https://issues.folio.org/browse/MODGOBI-43
Example: https://issues.folio.org/browse/MODORDERS-70
-->

## Approach
Expand All @@ -35,13 +30,13 @@
developers *work* with your solution in the future.
-->

#### TODOS and Open Questions
<!-- OPTIONAL
- [ ] Use GitHub checklists. When solved, check the box and explain the answer.
#### TODOS and Open Questions
[ ] Use GitHub checklists. When solved, check the box and explain the answer.
-->

## Learning
<!-- OPTIONAL
## Learning
Help out not only your reviewer, but also your fellow developer!
Sometimes there are key pieces of information that you used to come up
with your solution. Don't let all that hard work go to waste! A
Expand All @@ -52,31 +47,27 @@

## Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.

- [ ] I've added appropriate record to the CHANGELOG.md
- Does this PR meet or exceed the expected quality standards?
- [ ] Code coverage on new code is 80% or greater
- [ ] Duplications on new code is 3% or less
- [ ] There are no major code smells or security issues
- Does this introduce breaking changes?
- [ ] Were any API paths or methods changed, added or removed?
- [ ] Were there any schema changes?
- [ ] Did any of the interface versions change?
- [ ] Were permissions changed, added, or removed?
- [ ] Are there new interface dependencies?
- [ ] If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
- [ ] There are no breaking changes in this PR.

If there are breaking changes, please **STOP** and consider the following:

- What other modules will these changes impact?
- Do JIRAs exist to update the impacted modules?
- [ ] If not, please create them
- [ ] Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
- [ ] Do they have all they appropriate links to blocked/related issues?
- Are the JIRAs under active development?
- Are the JIRAs under active development?
- [ ] If not, contact the project's PO and make sure they're aware of the urgency.
- Do PRs exist for these changes?
- [ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

0 comments on commit 94d0862

Please sign in to comment.