[MODORDERS-964] Update acq-models

[alb3rtino]

Purpose

This PR updates acq-models to include the customFields attribute to purchase orders and purchase order lines. This is part of the custom fields integration. See MODORDERS-964.

Prerequisite

• MODORDSTOR PR#374

Related

• MODGOBI PR#220
• MODINVOICE PR#460
• MODINVOSTO PR#167

[SerhiiNosko]

@alb3rtino we also need to create PR with updating models for mod-gobi repository, because it also uses the same schemas

[alb3rtino]

MODGOBI PR#220

[SerhiiNosko]

checked that also need to create similar PRs to update references in mod-invoice, mod-invoice-storage
https://github.com/folio-org/mod-invoice/blob/master/descriptors/ModuleDescriptor-template.json#L574

[alb3rtino]

Taking a closer look at this, as schemas for composite_po_line and composite_purchase_order have had additions, we might want to increase interface versions too, right?

order-lines -> 3.3
orders -> 12.1

[alb3rtino]

I've updated to provided interface versions to

order-lines -> 3.3
orders -> 12.1

and the required interface versions to

orders-storage.po-lines -> 12.3
orders-storage.purchase-orders -> 8.1

This requires a merge of MODORDSTOR PR#374 first, so i've added the 'do not merge' tag.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[alb3rtino]

@SerhiiNosko I've made updates to the interface versions. Could you please review them? I'm uncertain whether the updated required interfaces require a module major version increase or not.

[SerhiiNosko]

As I remember if we increase from 12.0 to 12.1 - Okapi will not throw an error, even if in mod-gobi required version is 12.0 https://github.com/folio-org/mod-gobi/blob/master/descriptors/ModuleDescriptor-template.json#L157
If we for example we increased from 12.0 to 13.0 and in mod-gobi remain 12.0 - Okapi will throw an error during enabling the module.
But you can check my words using karate tests(acquisition folder in folio-integration-test) or just locally.

Basically we not always follow the rule to update minor version when adding new field, but in case when you increased it also would be a good practice to increase in these modules as well:
https://github.com/folio-org/mod-invoice/blob/master/descriptors/ModuleDescriptor-template.json#L664
https://github.com/folio-org/mod-gobi/blob/master/descriptors/ModuleDescriptor-template.json#L157
https://github.com/folio-org/mod-ebsconet/blob/master/descriptors/ModuleDescriptor-template.json#L6

[SerhiiNosko]

Basically I am ok to keep major versions for example in mod-gobi 12.0 and in orders increase to 12.1. It should work