[MODORDERS-1209]. Add more logs

folio-org · Dec 4, 2024 · 836a422 · 836a422
1 parent d41dd59
commit 836a422
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/src/main/java/org/folio/service/claiming/ClaimingService.java b/src/main/java/org/folio/service/claiming/ClaimingService.java
@@ -104,7 +104,7 @@ public Future<ClaimingResults> sendClaims(ClaimingCollection claimingCollection,
             return createJobsByVendor(config, pieceIdsByVendorIds, requestContext);
           });
       })
-      .onFailure(t -> logger.error("sendClaims :: Failed send claims: {}", JsonObject.mapFrom(claimingCollection).encodePrettily(), t));
+      .onFailure(t -> logger.error("sendClaims:: Failed send claims: {}", JsonObject.mapFrom(claimingCollection).encodePrettily(), t));
   }
 
   private Future<Map<String, List<String>>> groupPieceIdsByVendorId(List<String> pieceIds, RequestContext requestContext) {

diff --git a/src/main/java/org/folio/service/pieces/PieceStorageService.java b/src/main/java/org/folio/service/pieces/PieceStorageService.java
@@ -162,11 +162,19 @@ public Future<List<Piece>> getPiecesByIds(List<String> pieceIds, RequestContext
       .map(query -> getAllPieces(query, requestContext))
       .toList();
     return collectResultsOnSuccess(futures)
-      .map(lists -> lists.stream()
-        .map(PieceCollection::getPieces)
-        .flatMap(Collection::stream)
-        .toList())
-      .onSuccess(v -> log.info("getPiecesByIds:: pieces by ids successfully retrieve: {}", pieceIds));
+      .map(lists -> {
+        try {
+          return lists.stream()
+            .map(PieceCollection::getPieces)
+            .flatMap(Collection::stream)
+            .toList();
+        } catch (Throwable t) {
+          log.error("Failed to unwrap piece chunks");
+          throw t;
+        }
+      })
+      .onSuccess(v -> log.info("getPiecesByIds:: pieces by ids successfully retrieve: {}", pieceIds))
+      .onFailure(t -> log.error("Failed to get pieces by ids"));
   }
 
   public Future<List<Piece>> getPiecesByLineIdsByChunks(List<String> lineIds, RequestContext requestContext) {