Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODOAIPMH-576 Update source-storage-records and source-storage-source-records versions and rename module permissions #379

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dmytrokrutii
Copy link

@dmytrokrutii dmytrokrutii commented Sep 26, 2024

MODOAIPMH-576

Purpose

According to the epic https://folio-org.atlassian.net/browse/FOLIO-4044, some permissions have been changed in the source-storage-records v3.3 and source-storage-source-records v3.2

mod-oai-pmh uses the following outdated permissions:

"source-storage.records.get"
"source-storage.sourceRecords.get”

Permission Enpoint
source-storage.source-records.item.get /source-storage/source-records/{id}
source-storage.source-records.collection.get /source-storage/source-records

TODOS and Open Questions

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

@dmytrokrutii dmytrokrutii marked this pull request as draft September 26, 2024 12:45
@dmytrokrutii dmytrokrutii changed the title MODOAIPMH-576 Rename module-permission MODOAIPMH-576 Update source-storage-records and source-storage-source-records versions and rename module permissions Oct 8, 2024
@dmytrokrutii dmytrokrutii marked this pull request as ready for review October 8, 2024 12:58
Copy link

sonarcloud bot commented Oct 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants