MODOAIPMH-433 - embedded-postgresql-maven-plugin -> docker-maven-plugin #301
Conversation
…nto MODOAIPMH-433-docker-approach
| </configuration> | ||
| <groupId>io.fabric8</groupId> | ||
| <artifactId>docker-maven-plugin</artifactId> | ||
| <version>0.22.1</version> | ||
| <executions> |
There was a problem hiding this comment.
Before starting the database you need to clean up a left-over database from a previous run where a maven phase after prepare-database but before stop-database has failed:
<execution>
<id>stop-previous-database</id>
<phase>generate-sources</phase>
<goals>
<goal>stop</goal>
</goals>
</execution>
| <postgres.docker.env.POSTGRES_DB>localhost</postgres.docker.env.POSTGRES_DB> | ||
| <postgres.docker.envRun.POSTGRES_PASSWORD>postgres</postgres.docker.envRun.POSTGRES_PASSWORD> | ||
| <postgres.docker.envRun.POSTGRES_USER>postgres</postgres.docker.envRun.POSTGRES_USER> |
There was a problem hiding this comment.
I don't see any usage of these variables. Can they be removed?
| <postgres.docker.envRun.POSTGRES_PASSWORD>postgres</postgres.docker.envRun.POSTGRES_PASSWORD> | ||
| <postgres.docker.envRun.POSTGRES_USER>postgres</postgres.docker.envRun.POSTGRES_USER> | ||
| <postgres.docker.log.prefix>postgres</postgres.docker.log.prefix> | ||
| <postgres.docker.name>postgres:12.0</postgres.docker.name> |
There was a problem hiding this comment.
Can .0 be removed so that the latest version 12 release is used?
We don't want vulnerable components in the build.
|
@julianladisch , thank you for assistance in CI configuration! |
|
@julianladisch as we work with docker in docker, should DOCKER_HOST be defined to be sure socket is the same? |
…nto MODOAIPMH-433-docker-approach
|
testcontainers support starting another Docker container inside a Docker container in scenarios like Jenkins CI: docker-maven-plugin doesn't support this. It is a known issue: |
|
I suggest this hack: Hard-code the gateway IP. FOLIO's Jenkins uses the default gateway IP. https://github.com/folio-org/mod-oai-pmh/tree/MODOAIPMH-433-docker-approach-julian |
MODOAIPMH-433 - Unable to build on ARM
Purpose
Support ARM architecture
Approach
Replace maven-embedded-postgres-client to docker-maven-plugin
TODOS and Open Questions
How to verify build on ARM architecture?
Learning
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.