[MODINVOICE-482] Using the new transaction batch endpoint

[damien-git]

Purpose

MODINVOICE-482 - Accumulate all transactions in holder to make only single call to mod-finance

Approach

See ticket.

TODOS and Open Questions

• We should make sure that transaction updates have a metadata property when using the batch endpoint. Previously the create date and created by were lost in some cases because the metadata was missing.
• Metadata update date needs to be updated in mod-finance-storage. I added that to MODFISTO-432.
• There are 2 unit test errors in my environment, which are not related to these changes. It is not clear what is causing them:

[ERROR]   ApiTestSuite$VouchersApiTestNested>VouchersApiTest.testGetVouchersVoucherByIdInvalidFormat:120->ApiTestBase.verifyGet:376->ApiTestBase.verifyGet:387 1 expectation failed.
Expected status code <400> but was <404>.[ERROR]   ApiTestSuite$VouchersApiTestNested>VouchersApiTest.testPutVouchersVoucherByIdInvalidFormat:223->ApiTestBase.verifyPut:356->ApiTestBase.verifyPut:368 1 expectation failed.
Expected status code <400> but was <404>.

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate action.

• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code are 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • Were any API paths or methods changed, added, or removed?
  • Were there any schema changes?
  • Did any of the interface versions change?
  • Were permissions changed, added, or removed?
  • Are there new interface dependencies?
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all the appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[imerabishvili]

Kudos to @damien-git

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
85.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud