-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODFISTO - 501] - Implement endpoint to save FY finance data in bulk #439
Conversation
String fullBudgetTableName = getFullTableName(conn.getTenantId(), BUDGET_TABLE); | ||
String fullFYTableName = getFullTableName(conn.getTenantId(), FISCAL_YEAR_TABLE); | ||
|
||
String sql = "UPDATE " + fullBudgetTableName + " SET jsonb = jsonb_set(jsonb,'{budgetStatus}', $1) " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would probably be better to move to a static variable and use via .formatted()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, moved to static variabla, thanks
if (event.result() != null) { | ||
promise.complete(event.result().getFundStatus() != fund.getFundStatus()); | ||
fundService.updateFund(fund, new RequestContext(vertxContext, okapiHeaders)) | ||
.onComplete(result -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onSuccess and onFailure can be used, easier to read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, refactored
Also sonar issue for unused import can be addressed |
src/main/resources/templates/db_scripts/all_finance_data_view.sql
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Purpose
https://folio-org.atlassian.net/browse/MODFISTO-501
Approach