Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODELINKS-267: Extend Authority with saft* fields having custom mapping #342

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

elena-shmygaliova
Copy link
Collaborator

@elena-shmygaliova elena-shmygaliova commented Oct 23, 2024

MODELINKS-267

Purpose

For ASA customer it is required to exclude subfields “i” and numeric subfields from the mapping for 5xx fields in Authority.
Example:
$w r $i Successor: $a Sri Lanka $4 http://rdaregistry.info/Elements/u/P60686 $0 (DLC)n 80061039 $0 http://id.loc.gov/authorities/names/n80061039 $1 http://id.loc.gov/rwo/agents/n80061039
should be transformed to Sri Lanka, not to Successor: Sri Lanka http://rdaregistry.info/Elements/u/P60686

Approach

Additional fields with “Trunc” postfix are created like "saftGenreTermTrunc", "saftGeographicNameTrunc", etc. for the truncated mapping. Original saft* fields are kept without any changes.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

List any Jira issues related to this pull request.

Learning and Resources (if applicable)

Discuss any research conducted during the development of this pull request. Include links to relevant blog posts, patterns, libraries, or addons that were used to solve the problem.

Screenshots (if applicable)

If this pull request involves any visual changes or new features, consider including screenshots or GIFs to illustrate the changes.

@elena-shmygaliova elena-shmygaliova requested a review from a team as a code owner October 23, 2024 05:18
Copy link

@elena-shmygaliova elena-shmygaliova merged commit bf69005 into master Oct 23, 2024
7 checks passed
@elena-shmygaliova elena-shmygaliova deleted the MODELINKS-267-Extend-Authority-Mapping branch October 23, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants